starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #1237] [MERGED] Initializes conhost's Campbell color scheme in conhost order instead of ANSI/VT order #24538

New Issue
Open
opened 2026-01-31 09:03:53 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:03:53 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/1237
Author: @zadjii-msft
Created: 6/12/2019
Status: ✅ Merged
Merged: 7/25/2019
Merged by: @undefined

Base: master ← Head: dev/migrie/b/1234-colortable-order

📝 Commits (4)

  • 60d9c9d Fix this
  • 6513c72 Merge branch 'master' into dev/migrie/b/1234-colortable-order
  • dc6caa2 Swap the elements instead of having two whole tables
  • 6a9c96f Add a unittest to make @miniksa happy

📊 Changes

4 files changed (+92 additions, -27 deletions)

View changed files

📝 src/host/settings.cpp (+2 -2)
📝 src/types/inc/utils.hpp (+2 -0)
📝 src/types/ut_types/UtilsTests.cpp (+57 -24)
📝 src/types/utils.cpp (+31 -1)

📄 Description

Summary of the Pull Request

Switch conhost back to BGR order instead of RGB order.

PR Checklist

Validation Steps Performed

I ran openvt, as shown in the original bug

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/1237 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 6/12/2019 **Status:** ✅ Merged **Merged:** 7/25/2019 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/migrie/b/1234-colortable-order` --- ### 📝 Commits (4) - [`60d9c9d`](https://github.com/microsoft/terminal/commit/60d9c9d6f7b63dc5c93468bc357929c27d554f48) Fix this - [`6513c72`](https://github.com/microsoft/terminal/commit/6513c72367a2a0832cb1e2273028c91b3924af5c) Merge branch 'master' into dev/migrie/b/1234-colortable-order - [`dc6caa2`](https://github.com/microsoft/terminal/commit/dc6caa2ba8021a7c43d019aeba6523dec1b814b7) Swap the elements instead of having two whole tables - [`6a9c96f`](https://github.com/microsoft/terminal/commit/6a9c96f405379b13ebb6691d666d7856f2293bcf) Add a unittest to make @miniksa happy ### 📊 Changes **4 files changed** (+92 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `src/host/settings.cpp` (+2 -2) 📝 `src/types/inc/utils.hpp` (+2 -0) 📝 `src/types/ut_types/UtilsTests.cpp` (+57 -24) 📝 `src/types/utils.cpp` (+31 -1) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Switch conhost back to BGR order instead of RGB order. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #1234 <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed I ran `openvt`, as shown in the original bug --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:03:53 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24538
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?