starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #1218] [MERGED] Minor fixes #24539

New Issue
Open
opened 2026-01-31 09:03:54 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:03:54 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/1218
Author: @HBelusca
Created: 6/12/2019
Status: ✅ Merged
Merged: 6/13/2019
Merged by: @DHowett-MSFT

Base: master ← Head: minor_fixes

📝 Commits (3)

  • b792c89 Cascadia/TerminalConnection: Close the output thread on exit.
  • 3ea8f85 VtPipeTerm: Don't crash when closing the app.
  • 3b6108a Cascadia/TerminalConnection: Finish to implement the ConhostConnection::Close() 'TODO' block.

📊 Changes

2 files changed (+13 additions, -8 deletions)

View changed files

📝 src/cascadia/TerminalConnection/ConhostConnection.cpp (+8 -7)
📝 src/tools/vtpipeterm/VtConsole.cpp (+5 -1)

📄 Description

Summary of the Pull Request

I try to fix what looked as a "FIXME" to me (under question), and a crash when using the test-app VtPipeTerm.

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed (performed manually only)
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

I would like to have feedback on this commit:

Cascadia/TerminalConnection: Close the output thread on exit.
It seems that TerminateThread() is available in the code...

The following one concerns VtPipeTerm:

VtPipeTerm: Don't crash when closing the app.
- Gracefully handle ReadFile returning false (usually because of ERROR_BROKEN_PIPE on exit).
- Minor whitespace formatting.

Validation Steps Performed

Manual tests only, by starting, interacting with, and closing the programs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/1218 **Author:** [@HBelusca](https://github.com/HBelusca) **Created:** 6/12/2019 **Status:** ✅ Merged **Merged:** 6/13/2019 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `minor_fixes` --- ### 📝 Commits (3) - [`b792c89`](https://github.com/microsoft/terminal/commit/b792c8965e39d6620594da6cf4eadc32c4ba96b1) Cascadia/TerminalConnection: Close the output thread on exit. - [`3ea8f85`](https://github.com/microsoft/terminal/commit/3ea8f853b8759d912373dbe87440d3c09a331b7a) VtPipeTerm: Don't crash when closing the app. - [`3b6108a`](https://github.com/microsoft/terminal/commit/3b6108a8f34b186023d1fceaca04b00dec920795) Cascadia/TerminalConnection: Finish to implement the ConhostConnection::Close() 'TODO' block. ### 📊 Changes **2 files changed** (+13 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalConnection/ConhostConnection.cpp` (+8 -7) 📝 `src/tools/vtpipeterm/VtConsole.cpp` (+5 -1) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request I try to fix what looked as a "FIXME" to me (under question), and a crash when using the test-app VtPipeTerm. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [ ] Closes #xxx * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [x] Tests added/passed **_(performed manually only)_** * [ ] Requires documentation to be updated * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments I would like to have feedback on this commit: ``` Cascadia/TerminalConnection: Close the output thread on exit. It seems that TerminateThread() is available in the code... ``` The following one concerns VtPipeTerm: ``` VtPipeTerm: Don't crash when closing the app. - Gracefully handle ReadFile returning false (usually because of ERROR_BROKEN_PIPE on exit). - Minor whitespace formatting. ``` <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed Manual tests only, by starting, interacting with, and closing the programs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:03:54 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24539
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?