starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #1224] Add support for HTML copy #24545

New Issue
Closed
opened 2026-01-31 09:03:55 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:03:55 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/microsoft/terminal/pull/1224

State: closed
Merged: Yes

Summary of the Pull Request

HTML data is now copied to the clipboard. I tried reusing the old clipboard method so I had to move some stuff around. The design is pretty straightforward. Instead of sending just text data up on a CopyToClipboard event, send the HTML data up too in the same winrt object.

Here's some specifics:

  • Clipboard::GenHTML() Changes:
    • moved from Clipboard to TextBuffer
    • added iFontHeightPoints and fontFaceName so that I don't depend on the ServiceLocator
  • TermControl: have CopyToClipboardEventArgs have space for both data types
  • TerminalApp: just extract the data from the event and put it into the clipboard

References

#1146 (HTML portion)

PR Checklist

  • Closes half of install problem in version1809 (#1146)
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan.

Detailed Description of the Pull Request / Additional comments

I do have a few things I'm not sure of:

  • As of now, HTML copy is always enabled. I can easily add make it optional but idk what the design should look like (i.e.: new keybinding copies only HTML?)
  • I don't think we can/should add tests to this because (1) it resuses old code and (2) we definitely don't want to actually copy stuff to the clipboard during a test. The only thing to test would be what GenHTML does but that was already here.
  • Not sure if the iFontHeightPointsis right (or even described properly for that matter) in GenHTML().
    • for Clipboard we do int const iFontHeightPoints = fontData.GetUnscaledSize().Y * 72 / ServiceLocator::LocateGlobals().dpi;
    • for TermControl I did fontData.GetUnscaledSize().Y
    • I don't really know how to verify if this is correct. But I also don't know if we actually even need the DPI here. Thoughts?

Validation Steps Performed

Copy selections and paste to MSWord (regular text vs formatted text)

**Original Pull Request:** https://github.com/microsoft/terminal/pull/1224 **State:** closed **Merged:** Yes --- <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request HTML data is now copied to the clipboard. I tried reusing the old clipboard method so I had to move some stuff around. The design is pretty straightforward. Instead of sending just text data up on a `CopyToClipboard` event, send the HTML data up too in the same winrt object. Here's some specifics: - `Clipboard::GenHTML()` Changes: - moved from `Clipboard` to `TextBuffer` - added `iFontHeightPoints` and `fontFaceName` so that I don't depend on the `ServiceLocator` - `TermControl`: have `CopyToClipboardEventArgs` have space for both data types - `TerminalApp`: just extract the data from the event and put it into the clipboard <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References #1146 (HTML portion) <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes half of #1146 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Requires documentation to be updated * [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments I do have a few things I'm not sure of: - As of now, HTML copy is always enabled. I can easily add make it optional but idk what the design should look like (i.e.: new keybinding copies only HTML?) - I don't think we can/should add tests to this because (1) it resuses old code and (2) we definitely don't want to actually copy stuff to the clipboard during a test. The only thing to test would be what `GenHTML` does but that was already here. - Not sure if the `iFontHeightPoints`is right (or even described properly for that matter) in `GenHTML()`. - for `Clipboard` we do `int const iFontHeightPoints = fontData.GetUnscaledSize().Y * 72 / ServiceLocator::LocateGlobals().dpi;` - for `TermControl` I did `fontData.GetUnscaledSize().Y` - I don't really know how to verify if this is correct. But I also don't know if we actually even need the DPI here. Thoughts? ## Validation Steps Performed Copy selections and paste to MSWord (regular text vs formatted text)
claunia added the pull-request label 2026-01-31 09:03:55 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24545
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?