[PR #1258] [MERGED] Draft Spec for Cascading Default + User Settings #24548

Open
opened 2026-01-31 09:03:56 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/1258
Author: @zadjii-msft
Created: 6/14/2019
Status: Merged
Merged: 8/20/2019
Merged by: @zadjii-msft

Base: masterHead: dev/migrie/s/754-cascading-settings-spec


📝 Commits (10+)

  • d0a3cf5 Start working on drafting this spec
  • fe41a00 Merge remote-tracking branch 'origin/master' into dev/migrie/s/754-cascading-settings-spec
  • d2d8418 Really add a LOT of notes
  • 919836a More spec updates.
  • 40b77e1 Finish remaining TODO sections
  • ab2308a Apply suggestions from code review
  • f100227 Lots of feedback from PR
  • c290461 Merge branch 'dev/migrie/s/754-cascading-settings-spec' of https://github.com/Microsoft/Terminal into dev/migrie/s/754-cascading-settings-spec
  • 7aa0c42 Merge remote-tracking branch 'origin/release-0.3' into dev/migrie/s/754-cascading-settings-spec
  • dd2c4db Add updates concerning dynamic profile generation (#1321)

📊 Changes

1 file changed (+717 additions, -0 deletions)

View changed files

doc/cascadia/Cascading-Default-Settings.md (+717 -0)

📄 Description

Summary of the Pull Request

Adds a spec describing how a cascading settings model should work. This spec describes a model where there are two sets of settings, "Default" and "User" settings, and the two are layered to create the runtime settings.

PR Checklist

  • Specs VS failed to build with many errors (#754)
  • CLA signed. If not, go over here and sign the CLA
  • [N/A] Tests added/passed
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Just read the spec.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/1258 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 6/14/2019 **Status:** ✅ Merged **Merged:** 8/20/2019 **Merged by:** [@zadjii-msft](https://github.com/zadjii-msft) **Base:** `master` ← **Head:** `dev/migrie/s/754-cascading-settings-spec` --- ### 📝 Commits (10+) - [`d0a3cf5`](https://github.com/microsoft/terminal/commit/d0a3cf54ffb38a6d9eb3cd7df4299f4effba4606) Start working on drafting this spec - [`fe41a00`](https://github.com/microsoft/terminal/commit/fe41a00c754153a68c0184b1baa35af96604820e) Merge remote-tracking branch 'origin/master' into dev/migrie/s/754-cascading-settings-spec - [`d2d8418`](https://github.com/microsoft/terminal/commit/d2d841824ccb75e9bbfefe53451951f2439a2cf5) Really add a LOT of notes - [`919836a`](https://github.com/microsoft/terminal/commit/919836aa12721ec9754760c424b4654d4e42e428) More spec updates. - [`40b77e1`](https://github.com/microsoft/terminal/commit/40b77e1073149224a16fff6f199b4e8226eb6d5e) Finish remaining TODO sections - [`ab2308a`](https://github.com/microsoft/terminal/commit/ab2308a36200a1c217e2af681244ac5f1ac85574) Apply suggestions from code review - [`f100227`](https://github.com/microsoft/terminal/commit/f1002270cc9f6f744ba441f58450be1ca305e5cb) Lots of feedback from PR - [`c290461`](https://github.com/microsoft/terminal/commit/c2904619141763bbc9240e27f040a7dd6efcae39) Merge branch 'dev/migrie/s/754-cascading-settings-spec' of https://github.com/Microsoft/Terminal into dev/migrie/s/754-cascading-settings-spec - [`7aa0c42`](https://github.com/microsoft/terminal/commit/7aa0c423614da69680c845c6af7777089a55c1a7) Merge remote-tracking branch 'origin/release-0.3' into dev/migrie/s/754-cascading-settings-spec - [`dd2c4db`](https://github.com/microsoft/terminal/commit/dd2c4db73576965fcb6b7eff683b233eb43c0181) Add updates concerning dynamic profile generation (#1321) ### 📊 Changes **1 file changed** (+717 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `doc/cascadia/Cascading-Default-Settings.md` (+717 -0) </details> ### 📄 Description ## Summary of the Pull Request Adds a spec describing how a cascading settings model should work. This spec describes a model where there are two sets of settings, "Default" and "User" settings, and the two are layered to create the runtime settings. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Specs #754 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [N/A] Tests added/passed * [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments Just read the spec. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:03:56 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24548