starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #1273] [MERGED] Multi-Click Selection: Double-Click Settings #24556

New Issue
Open
opened 2026-01-31 09:03:59 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:03:59 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/1273
Author: @carlos-zamora
Created: 6/14/2019
Status: ✅ Merged
Merged: 7/10/2019
Merged by: @carlos-zamora

Base: dev/cazamor/multi-click-selection ← Head: dev/cazamor/mcs/2x-settings

📝 Commits (5)

  • bc0c746 Added delimiter settings for double click selection
  • f080f0f code format (how do I keep doing this?)
  • 69549d7 PR Changes
  • 5fb0c0a changed default
  • 70482d4 Changed to constant

📊 Changes

8 files changed (+41 additions, -15 deletions)

View changed files

📝 src/cascadia/TerminalApp/Profile.cpp (+17 -0)
📝 src/cascadia/TerminalApp/Profile.h (+2 -0)
📝 src/cascadia/TerminalCore/Terminal.cpp (+3 -15)
📝 src/cascadia/TerminalCore/Terminal.hpp (+1 -0)
📝 src/cascadia/TerminalSettings/ICoreSettings.idl (+2 -0)
📝 src/cascadia/TerminalSettings/TerminalSettings.cpp (+11 -0)
📝 src/cascadia/TerminalSettings/terminalsettings.h (+3 -0)
📝 src/inc/DefaultSettings.h (+2 -0)

📄 Description

Summary of the Pull Request

Delimiters for double click can now be set in settings. This is on a per profile basis (shoutout to all the WSL users out there).

References

The first of a few additions to Multi-Click Selection (#1197).
Contributes to #988

PR Checklist

  • Doesn't close issue. Please read above.
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

  • TerminalSettings:
    • add property to winrt TerminalSettings
  • Terminal App:
    • read/write JSON for this new property
    • default set to " /\"
  • TerminalCore:
    • import/use delimiters from ICoreSettings

Validation Steps Performed

  • modified profiles.json. Then performed double click in an instance of that profile

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/1273 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 6/14/2019 **Status:** ✅ Merged **Merged:** 7/10/2019 **Merged by:** [@carlos-zamora](https://github.com/carlos-zamora) **Base:** `dev/cazamor/multi-click-selection` ← **Head:** `dev/cazamor/mcs/2x-settings` --- ### 📝 Commits (5) - [`bc0c746`](https://github.com/microsoft/terminal/commit/bc0c746e81f20052fe28f40916e344b37be227fd) Added delimiter settings for double click selection - [`f080f0f`](https://github.com/microsoft/terminal/commit/f080f0fa54ac6b214845be167bb5df75ce31891c) code format (how do I keep doing this?) - [`69549d7`](https://github.com/microsoft/terminal/commit/69549d7c1676af49a57d11ee0d453a73d1c3d67e) PR Changes - [`5fb0c0a`](https://github.com/microsoft/terminal/commit/5fb0c0a23ee2f373429969cd31e3063df862e913) changed default - [`70482d4`](https://github.com/microsoft/terminal/commit/70482d4ec22baa0c9070f8b47b7e6f663aa56f8c) Changed to constant ### 📊 Changes **8 files changed** (+41 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/Profile.cpp` (+17 -0) 📝 `src/cascadia/TerminalApp/Profile.h` (+2 -0) 📝 `src/cascadia/TerminalCore/Terminal.cpp` (+3 -15) 📝 `src/cascadia/TerminalCore/Terminal.hpp` (+1 -0) 📝 `src/cascadia/TerminalSettings/ICoreSettings.idl` (+2 -0) 📝 `src/cascadia/TerminalSettings/TerminalSettings.cpp` (+11 -0) 📝 `src/cascadia/TerminalSettings/terminalsettings.h` (+3 -0) 📝 `src/inc/DefaultSettings.h` (+2 -0) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Delimiters for double click can now be set in settings. This is on a **per profile** basis (shoutout to all the WSL users out there). <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References The first of a few additions to Multi-Click Selection (#1197). Contributes to #988 <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Doesn't close issue. Please read above. * [ ] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Requires documentation to be updated * [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments - TerminalSettings: - add property to winrt TerminalSettings - Terminal App: - read/write JSON for this new property - default set to " /\\" - TerminalCore: - import/use delimiters from ICoreSettings <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed - modified profiles.json. Then performed double click in an instance of that profile --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:03:59 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24556
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?