[PR #1270] [MERGED] split code format check into its own job #24559

Open
opened 2026-01-31 09:04:00 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/1270
Author: @adiviness
Created: 6/14/2019
Status: ✅ Merged
Merged: 6/14/2019
Merged by: @zadjii-msft

Base: master ← Head: dev/austdi/format-separate-job


📝 Commits (3)

  • 8f9f21a split code format check into its own job
  • e44218d Update build/pipelines/templates/check-formatting.yml
  • f6dbab6 fix result check

📊 Changes

5 files changed (+23 additions, -7 deletions)

View changed files

📝 build/pipelines/ci.yml (+2 -0)
📝 build/pipelines/release.yml (+2 -0)
📝 build/pipelines/templates/build-console-audit-job.yml (+0 -6)
➕ build/pipelines/templates/check-formatting.yml (+16 -0)
📝 build/pipelines/templates/release-sign-and-bundle.yml (+3 -1)

📄 Description

Summary of the Pull Request

Split the code format check into its own job so it's easier to tell if it failed.

References

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/1270 **Author:** [@adiviness](https://github.com/adiviness) **Created:** 6/14/2019 **Status:** ✅ Merged **Merged:** 6/14/2019 **Merged by:** [@zadjii-msft](https://github.com/zadjii-msft) **Base:** `master` ← **Head:** `dev/austdi/format-separate-job` --- ### 📝 Commits (3) - [`8f9f21a`](https://github.com/microsoft/terminal/commit/8f9f21aca5b93fab4bde0d4c12cb5b20398e1aa0) split code format check into its own job - [`e44218d`](https://github.com/microsoft/terminal/commit/e44218d1f31ffb7ee7c9030061d63773d83bdf08) Update build/pipelines/templates/check-formatting.yml - [`f6dbab6`](https://github.com/microsoft/terminal/commit/f6dbab6d6b7c1c25cbb729d3a9ae66cc2417f269) fix result check ### 📊 Changes **5 files changed** (+23 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `build/pipelines/ci.yml` (+2 -0) 📝 `build/pipelines/release.yml` (+2 -0) 📝 `build/pipelines/templates/build-console-audit-job.yml` (+0 -6) ➕ `build/pipelines/templates/check-formatting.yml` (+16 -0) 📝 `build/pipelines/templates/release-sign-and-bundle.yml` (+3 -1) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Split the code format check into its own job so it's easier to tell if it failed. <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [ ] Closes #xxx * [ ] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Requires documentation to be updated * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:04:00 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24559