[PR #1283] [MERGED] Code highlighting and capitalization fix for doc/EXCEPTIONS.md #24568

Open
opened 2026-01-31 09:04:04 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/1283
Author: @azhuologist
Created: 6/16/2019
Status: ✅ Merged
Merged: 6/18/2019
Merged by: @undefined

Base: master ← Head: master


📝 Commits (2)

  • 9b8b41e Mark NTSTATUS, HRESULT, and wil::unique_ptr as inline code snippets
  • 5421c3b Change encapsulate on line 14 to lower case to be consistent with the other rules

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 doc/EXCEPTIONS.md (+3 -3)

📄 Description

Summary of the Pull Request

Minor changes to the doc/EXCEPTIONS.md file: adding code highlighting to rules 2 and 5, and changing "Encapsulate" to "encapsulate" in rule 3 to be consistent with the other rules.

References

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/1283 **Author:** [@azhuologist](https://github.com/azhuologist) **Created:** 6/16/2019 **Status:** ✅ Merged **Merged:** 6/18/2019 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`9b8b41e`](https://github.com/microsoft/terminal/commit/9b8b41eaec31a36c6612a4aae1d2506661e403fc) Mark NTSTATUS, HRESULT, and wil::unique_ptr as inline code snippets - [`5421c3b`](https://github.com/microsoft/terminal/commit/5421c3b9161502788ee5fec8c3fedf8ab8ba5b0e) Change encapsulate on line 14 to lower case to be consistent with the other rules ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `doc/EXCEPTIONS.md` (+3 -3) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Minor changes to the `doc/EXCEPTIONS.md` file: adding code highlighting to rules 2 and 5, and changing "Encapsulate" to "encapsulate" in rule 3 to be consistent with the other rules. <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [ ] Closes #xxx * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Requires documentation to be updated * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:04:04 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24568