starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #1302] [CLOSED] Multi-Click Selection: Triple-Click Settings + Viewport Selection #24570

New Issue
Open
opened 2026-01-31 09:04:04 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:04:04 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/1302
Author: @carlos-zamora
Created: 6/17/2019
Status: ❌ Closed

Base: dev/cazamor/multi-click-selection ← Head: dev/cazamor/mcs/viewport-selection

📝 Commits (3)

  • d2e1be1 Viewport selection is now an option
  • 9db18ab Triple Click Settings
  • 23ae33c SelectionMode --> TripleClickSelectionMode

📊 Changes

8 files changed (+117 additions, -1 deletions)

View changed files

📝 src/cascadia/TerminalApp/Profile.cpp (+54 -0)
📝 src/cascadia/TerminalApp/Profile.h (+3 -0)
📝 src/cascadia/TerminalCore/Terminal.cpp (+32 -1)
📝 src/cascadia/TerminalCore/Terminal.hpp (+4 -0)
📝 src/cascadia/TerminalSettings/ICoreSettings.idl (+8 -0)
📝 src/cascadia/TerminalSettings/TerminalSettings.cpp (+11 -0)
📝 src/cascadia/TerminalSettings/terminalsettings.h (+3 -0)
📝 src/cascadia/UnitTests_TerminalCore/ScreenSizeLimitsTest.cpp (+2 -0)

📄 Description

Summary of the Pull Request

Introduces "viewport selection" which creates a selection of the entire viewport. Also, adds per-profile settings to decide whether a triple-click performs a line selection or viewport selection (disabling it is also an option).

References

Builds on #1197. Similar to #1273.
Closes #1084.

PR Checklist

  • Closes Move hard-coded strings and UI text to Resources (#1084)
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan.

Detailed Description of the Pull Request / Additional comments

  • TerminalSettings:
    • add property to winrt TerminalSettings
  • Terminal App:
    • read/write JSON for this new property
    • default set to line selection
  • TerminalCore:
    • import/use selection mode from ICoreSettings
    • perform proper action
  • UnitTests_TerminalCore:
    • Added setting to MockTermSettings

Validation Steps Performed

  • modified profiles.json. Then performed triple click in an instance of that profile

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/1302 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 6/17/2019 **Status:** ❌ Closed **Base:** `dev/cazamor/multi-click-selection` ← **Head:** `dev/cazamor/mcs/viewport-selection` --- ### 📝 Commits (3) - [`d2e1be1`](https://github.com/microsoft/terminal/commit/d2e1be1bf08a6d4386072b06b35f4eac3bb3543d) Viewport selection is now an option - [`9db18ab`](https://github.com/microsoft/terminal/commit/9db18ab1e0c8fde817ffc9e6b97cea003818d26a) Triple Click Settings - [`23ae33c`](https://github.com/microsoft/terminal/commit/23ae33cb8ff50f61da6d15189fc0e6802aeaae1b) SelectionMode --> TripleClickSelectionMode ### 📊 Changes **8 files changed** (+117 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/Profile.cpp` (+54 -0) 📝 `src/cascadia/TerminalApp/Profile.h` (+3 -0) 📝 `src/cascadia/TerminalCore/Terminal.cpp` (+32 -1) 📝 `src/cascadia/TerminalCore/Terminal.hpp` (+4 -0) 📝 `src/cascadia/TerminalSettings/ICoreSettings.idl` (+8 -0) 📝 `src/cascadia/TerminalSettings/TerminalSettings.cpp` (+11 -0) 📝 `src/cascadia/TerminalSettings/terminalsettings.h` (+3 -0) 📝 `src/cascadia/UnitTests_TerminalCore/ScreenSizeLimitsTest.cpp` (+2 -0) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Introduces "viewport selection" which creates a selection of the entire viewport. Also, adds per-profile settings to decide whether a triple-click performs a line selection or viewport selection (disabling it is also an option). <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References Builds on #1197. Similar to #1273. Closes #1084. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [ ] Closes #1084 * [ ] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Requires documentation to be updated * [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments - TerminalSettings: - add property to winrt TerminalSettings - Terminal App: - read/write JSON for this new property - default set to line selection - TerminalCore: - import/use selection mode from ICoreSettings - perform proper action - UnitTests_TerminalCore: - Added setting to `MockTermSettings` <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed - modified profiles.json. Then performed triple click in an instance of that profile --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:04:04 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24570
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?