[PR #1330] [MERGED] Allow file modifications to quiet down before reloading settings #24586

Open
opened 2026-01-31 09:04:12 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/1330
Author: @DHowett-MSFT
Created: 6/19/2019
Status: ✅ Merged
Merged: 6/19/2019
Merged by: @DHowett-MSFT

Base: master ← Head: dev/duhowett/quiet_time


📝 Commits (2)

  • 142eb96 Allow file modifications to quiet down before reloading settings
  • d957e1d Update src/cascadia/TerminalApp/App.cpp

📊 Changes

2 files changed (+19 additions, -1 deletions)

View changed files

📝 src/cascadia/TerminalApp/App.cpp (+16 -1)
📝 src/cascadia/TerminalApp/App.h (+3 -0)

📄 Description

This commit introduces a 50ms debounce so that we stop flapping around while text editors are making directory changes.
Fixes #1329.

Tested

  • Write from VSCode (hold down Ctrl+S, go mad with power)
  • Write from vim
  • Write invalid settings
  • Run multiple terminals simultaneously and do the above.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/1330 **Author:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Created:** 6/19/2019 **Status:** ✅ Merged **Merged:** 6/19/2019 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `dev/duhowett/quiet_time` --- ### 📝 Commits (2) - [`142eb96`](https://github.com/microsoft/terminal/commit/142eb96d64032f49af25f2593185f8893c498cbf) Allow file modifications to quiet down before reloading settings - [`d957e1d`](https://github.com/microsoft/terminal/commit/d957e1d5832bed94476d13c5e27303bfabc356da) Update src/cascadia/TerminalApp/App.cpp ### 📊 Changes **2 files changed** (+19 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/App.cpp` (+16 -1) 📝 `src/cascadia/TerminalApp/App.h` (+3 -0) </details> ### 📄 Description This commit introduces a 50ms debounce so that we stop flapping around while text editors are making directory changes. Fixes #1329. ### Tested * Write from VSCode (hold down <kbd>Ctrl+S</kbd>, go mad with power) * Write from vim * Write invalid settings * Run multiple terminals simultaneously and do the above. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:04:12 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24586