[PR #1343] [MERGED] If we failed to get a default profile, fail the settings load #24590

Open
opened 2026-01-31 09:04:14 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/1343
Author: @DHowett-MSFT
Created: 6/20/2019
Status: Merged
Merged: 6/20/2019
Merged by: @DHowett-MSFT

Base: masterHead: dev/duhowett/defaultstopmaybe


📝 Commits (1)

  • 16e663e If we failed to get a default profile, fail the settings load

📊 Changes

1 file changed (+5 additions, -0 deletions)

View changed files

📝 src/cascadia/TerminalApp/CascadiaSettingsSerialization.cpp (+5 -0)

📄 Description

This stops the crash in #1318.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/1343 **Author:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Created:** 6/20/2019 **Status:** ✅ Merged **Merged:** 6/20/2019 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `dev/duhowett/defaultstopmaybe` --- ### 📝 Commits (1) - [`16e663e`](https://github.com/microsoft/terminal/commit/16e663ec390d32c34451ff804d1e711e5de884c4) If we failed to get a default profile, fail the settings load ### 📊 Changes **1 file changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/CascadiaSettingsSerialization.cpp` (+5 -0) </details> ### 📄 Description This stops the crash in #1318. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:04:14 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24590