starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #1349] [MERGED] Add a spec draft for Keybindings Arguments #24597

New Issue
Open
opened 2026-01-31 09:04:16 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:04:16 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/1349
Author: @zadjii-msft
Created: 6/20/2019
Status: ✅ Merged
Merged: 8/16/2019
Merged by: @zadjii-msft

Base: master ← Head: dev/migrie/s/1142-keybindings-args

📝 Commits (6)

  • 784528f Add a spec draft for Keybindings Arguments.
  • 4d5eb54 Apply suggestions from code review
  • 47f6e25 Merge branch 'master' into dev/migrie/s/1142-keybindings-args
  • dd03ced Include notes on reliability, security, and Handleing Keybinding Args
  • 56d042a Add some extra details from review
  • f326ce6 Updating spec to remove the bulk of the IActionArgs and IActionEventArgs implementations, as they're redundant.

📊 Changes

1 file changed (+362 additions, -0 deletions)

View changed files

➕ doc/cascadia/Keybindings-Arguments.md (+362 -0)

📄 Description

Summary of the Pull Request

The goal of this change is to both simplify the keybindings, and also enable far
more flexibility when editing a user's keybindings.

Currently, we have many actions that are very similar in implementation - for
example, newTabProfile0, newTabProfile1, newTabProfile2, etc. All these
actions are fundamentally the same function. However, we've needed to define 9
different actions to enable the user to provide different values to the newTab
function.

With this change, we'll be able to remove these essentially duplicated events,
and allow the user to specify arbitrary arguments to these functions.

References

Might play into #968, since there's some discussion of to munge or not to munge with the default keybinding for copy. This would make it easy to add both.

PR Checklist

Detailed Description of the Pull Request / Additional comments

Just read the spec :)

Validation Steps Performed

It's a spec.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/1349 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 6/20/2019 **Status:** ✅ Merged **Merged:** 8/16/2019 **Merged by:** [@zadjii-msft](https://github.com/zadjii-msft) **Base:** `master` ← **Head:** `dev/migrie/s/1142-keybindings-args` --- ### 📝 Commits (6) - [`784528f`](https://github.com/microsoft/terminal/commit/784528f00879910b398f95ec396cea3953a4324f) Add a spec draft for Keybindings Arguments. - [`4d5eb54`](https://github.com/microsoft/terminal/commit/4d5eb54015328d5993f925cacb12a6182b97c06f) Apply suggestions from code review - [`47f6e25`](https://github.com/microsoft/terminal/commit/47f6e25ffd0c19f226b1038ad5c8c30a50619e12) Merge branch 'master' into dev/migrie/s/1142-keybindings-args - [`dd03ced`](https://github.com/microsoft/terminal/commit/dd03ced38272443e1ae3078c948ffcbea2287b23) Include notes on reliability, security, and `Handle`ing Keybinding Args - [`56d042a`](https://github.com/microsoft/terminal/commit/56d042a5c748c0a4362899c61c1153653d91f403) Add some extra details from review - [`f326ce6`](https://github.com/microsoft/terminal/commit/f326ce69602b21d7cbe5842f2bad4aca8185e21e) Updating spec to remove the bulk of the `IActionArgs` and `IActionEventArgs` implementations, as they're redundant. ### 📊 Changes **1 file changed** (+362 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `doc/cascadia/Keybindings-Arguments.md` (+362 -0) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request The goal of this change is to both simplify the keybindings, and also enable far more flexibility when editing a user's keybindings. Currently, we have many actions that are very similar in implementation - for example, `newTabProfile0`, `newTabProfile1`, `newTabProfile2`, etc. All these actions are _fundamentally_ the same function. However, we've needed to define 9 different actions to enable the user to provide different values to the `newTab` function. With this change, we'll be able to remove these _essentially_ duplicated events, and allow the user to specify arbitrary arguments to these functions. <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References Might play into #968, since there's some discussion of _to munge or not to munge_ with the default keybinding for copy. This would make it easy to add _both_. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Specs #1142 <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments Just read the spec :) <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed It's a spec. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:04:16 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24597
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?