[PR #1358] [MERGED] Add support for setting a profile's tab title #24599

Open
opened 2026-01-31 09:04:16 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/1358
Author: @cinnamon-msft
Created: 6/21/2019
Status: ✅ Merged
Merged: 7/2/2019
Merged by: @cinnamon-msft

Base: master ← Head: cinnamon/custom-tab-name


📝 Commits (7)

  • 6fdc1d9 initial tab renaming functionality
  • 10a1995 fixed formatting
  • 4d57617 cleaned up code, added fixes and documentation
  • dc700d7 removed tabTitle from mockTermSettings
  • acbe50d Merge branch 'master' into cinnamon/custom-tab-name
  • 344ea52 code cleanup
  • 4837e7d Update src/cascadia/TerminalApp/App.cpp

📊 Changes

4 files changed (+59 additions, -6 deletions)

View changed files

📝 doc/cascadia/SettingsSchema.md (+1 -0)
📝 src/cascadia/TerminalApp/App.cpp (+14 -6)
📝 src/cascadia/TerminalApp/Profile.cpp (+40 -0)
📝 src/cascadia/TerminalApp/Profile.h (+4 -0)

📄 Description

Summary of the Pull Request

Added tab renaming functionality to profiles.json

References

PR Checklist

  • Closes Add fallback fonts to display more Unicode codepoints (#608)
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Added "tabTitle" : "insert title here" to a profile in the profiles.json


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/1358 **Author:** [@cinnamon-msft](https://github.com/cinnamon-msft) **Created:** 6/21/2019 **Status:** ✅ Merged **Merged:** 7/2/2019 **Merged by:** [@cinnamon-msft](https://github.com/cinnamon-msft) **Base:** `master` ← **Head:** `cinnamon/custom-tab-name` --- ### 📝 Commits (7) - [`6fdc1d9`](https://github.com/microsoft/terminal/commit/6fdc1d95f71791e6db4cef3d23232c1da03b41e2) initial tab renaming functionality - [`10a1995`](https://github.com/microsoft/terminal/commit/10a1995b614058f9fd986bebc15f4a2cdf4438b7) fixed formatting - [`4d57617`](https://github.com/microsoft/terminal/commit/4d5761754c587f0b2443053f350b31c5a0c58866) cleaned up code, added fixes and documentation - [`dc700d7`](https://github.com/microsoft/terminal/commit/dc700d705e38aa571aa9506f6718dac3f9713c53) removed tabTitle from mockTermSettings - [`acbe50d`](https://github.com/microsoft/terminal/commit/acbe50d14833891e0a7c21c1efb909cdf6756641) Merge branch 'master' into cinnamon/custom-tab-name - [`344ea52`](https://github.com/microsoft/terminal/commit/344ea5222b3ce48c6aaab4c7badfa67afac087c2) code cleanup - [`4837e7d`](https://github.com/microsoft/terminal/commit/4837e7d04a4e7fe3746fe326a99cea2b3959ea34) Update src/cascadia/TerminalApp/App.cpp ### 📊 Changes **4 files changed** (+59 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/SettingsSchema.md` (+1 -0) 📝 `src/cascadia/TerminalApp/App.cpp` (+14 -6) 📝 `src/cascadia/TerminalApp/Profile.cpp` (+40 -0) 📝 `src/cascadia/TerminalApp/Profile.h` (+4 -0) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Added tab renaming functionality to profiles.json <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #608 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [x] Tests added/passed * [ ] Requires documentation to be updated * [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed Added "tabTitle" : "insert title here" to a profile in the profiles.json --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:04:16 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24599