starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #1436] [MERGED] Fixed #521 - AltGr combinations not working #24606

New Issue
Open
opened 2026-01-31 09:04:19 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:04:19 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/1436
Author: @lhecker
Created: 6/22/2019
Status: ✅ Merged
Merged: 6/28/2019
Merged by: @DHowett-MSFT

Base: master ← Head: fix-altgr-handling

📝 Commits (1)

📊 Changes

7 files changed (+66 additions, -42 deletions)

View changed files

📝 src/cascadia/TerminalControl/TermControl.cpp (+32 -18)
📝 src/cascadia/TerminalControl/TermControl.h (+1 -1)
📝 src/cascadia/TerminalCore/ITerminalInput.hpp (+1 -1)
📝 src/cascadia/TerminalCore/Terminal.cpp (+21 -13)
📝 src/cascadia/TerminalCore/Terminal.hpp (+1 -4)
📝 src/cascadia/UnitTests_TerminalCore/InputTest.cpp (+3 -3)
📝 src/terminal/adapter/ut_adapter/inputTest.cpp (+7 -2)

📄 Description

Summary of the Pull Request

Let's start fixing #521 and the currently broken state of AltGr combinations, as it heavily affects many non-US users of this project.

PR Checklist

  • Closes iTerm color schemes once more are failing to parse colors (#521)
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #521

Detailed Description of the Pull Request / Additional comments

I'm about 100% sure that this PR is not going to fix #521 by itself, but it's a start. 🙂
If others wan't to contribute to this PR, please feel free to do so. I'll gladly grant push permissions to my fork.

If you want to view the diff here on GitHub I recommend enabling "Hide whitespace changes" in the diff viewer.

Validation Steps Performed

This PR fixes all immediate/obvious issues in regards to AltGr for me in all types of shells I know.
I think it's fairly easy to see why it works, since I simply delegate the handling to WM_CHAR instead.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/1436 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 6/22/2019 **Status:** ✅ Merged **Merged:** 6/28/2019 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `fix-altgr-handling` --- ### 📝 Commits (1) - [`0ad7f92`](https://github.com/microsoft/terminal/commit/0ad7f921670ffbedc75d5ac5e4e878b2a20efa90) Fixed #521 - AltGr combinations not working ### 📊 Changes **7 files changed** (+66 additions, -42 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+32 -18) 📝 `src/cascadia/TerminalControl/TermControl.h` (+1 -1) 📝 `src/cascadia/TerminalCore/ITerminalInput.hpp` (+1 -1) 📝 `src/cascadia/TerminalCore/Terminal.cpp` (+21 -13) 📝 `src/cascadia/TerminalCore/Terminal.hpp` (+1 -4) 📝 `src/cascadia/UnitTests_TerminalCore/InputTest.cpp` (+3 -3) 📝 `src/terminal/adapter/ut_adapter/inputTest.cpp` (+7 -2) </details> ### 📄 Description ## Summary of the Pull Request Let's start fixing #521 and the currently broken state of AltGr combinations, as it heavily affects many non-US users of this project. ## PR Checklist * [ ] Closes #521 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [x] Tests added/passed * [ ] Requires documentation to be updated * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #521 ## Detailed Description of the Pull Request / Additional comments I'm about 100% sure that this PR is not going to fix #521 by itself, but it's a start. 🙂 If others wan't to contribute to this PR, please feel free to do so. I'll gladly grant push permissions to my fork. If you want to view the diff here on GitHub I recommend enabling "Hide whitespace changes" in the diff viewer. ## Validation Steps Performed This PR fixes all immediate/obvious issues in regards to AltGr for me in all types of shells I know. I think it's fairly easy to see why it works, since I simply delegate the handling to `WM_CHAR` instead. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:04:19 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24606
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?