starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 16:05:21 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #1627] [MERGED] Replace caption buttons with ones that look close to correct #24629

New Issue
Open
opened 2026-01-31 09:04:28 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:04:28 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/1627
Author: @DHowett-MSFT
Created: 6/26/2019
Status: ✅ Merged
Merged: 7/1/2019
Merged by: @DHowett-MSFT

Base: master ← Head: dev/duhowett/minmaxcloseme

📝 Commits (3)

  • 4568b85 Replace MinMaxControl's buttons with ones that look really close to reality
  • 3c2d33f Address PR Feedback
  • 77329d1 Add a proper high contrast theme

📊 Changes

2 files changed (+167 additions, -6 deletions)

View changed files

📝 src/cascadia/TerminalApp/MinMaxCloseControl.cpp (+2 -0)
📝 src/cascadia/TerminalApp/MinMaxCloseControl.xaml (+165 -6)

📄 Description

Summary of the Pull Request

This pull request contains a bunch of XAML that makes our caption buttons look like this:

state image
normal image
hovered image
clicked image
maximized image

instead of like the characters _, - and X from Segoe UI.

References

Part of #1625.

PR Checklist

  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed/N/A
  • I've discussed this with core contributors already.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/1627 **Author:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Created:** 6/26/2019 **Status:** ✅ Merged **Merged:** 7/1/2019 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `dev/duhowett/minmaxcloseme` --- ### 📝 Commits (3) - [`4568b85`](https://github.com/microsoft/terminal/commit/4568b8561baf91444f05ae79b8b964605c70e42a) Replace MinMaxControl's buttons with ones that look really close to reality - [`3c2d33f`](https://github.com/microsoft/terminal/commit/3c2d33f827cf1a4d26e3b70f1d59e9bcb0b1c6d6) Address PR Feedback - [`77329d1`](https://github.com/microsoft/terminal/commit/77329d1d14cc1917faec859af979059c27e04202) Add a proper high contrast theme ### 📊 Changes **2 files changed** (+167 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/MinMaxCloseControl.cpp` (+2 -0) 📝 `src/cascadia/TerminalApp/MinMaxCloseControl.xaml` (+165 -6) </details> ### 📄 Description ## Summary of the Pull Request This pull request contains a bunch of XAML that makes our caption buttons look like this: |state|image| |-|-| |normal|![image](https://user-images.githubusercontent.com/14316954/60141892-55027f80-976c-11e9-8074-c8b77ca4a1d8.png)| |hovered|![image](https://user-images.githubusercontent.com/14316954/60141895-58960680-976c-11e9-89d2-08dbd664625f.png)| |clicked|![image](https://user-images.githubusercontent.com/14316954/60141898-5c298d80-976c-11e9-9a53-c9f394c3ca88.png)| |maximized|![image](https://user-images.githubusercontent.com/14316954/60141918-795e5c00-976c-11e9-83d4-fc0fe80acb57.png)| instead of like the characters `_`, `-` and `X` from Segoe UI. ## References Part of #1625. ## PR Checklist * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [x] Tests added/passed/N/A * [x] I've discussed this with core contributors already. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:04:28 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24629
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?