starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #1685] [MERGED] #1536 - Feature Request - Duplicate tab #24636

New Issue
Open
opened 2026-01-31 09:04:30 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:04:30 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/1685
Author: @dnagl
Created: 6/27/2019
Status: ✅ Merged
Merged: 7/2/2019
Merged by: @miniksa

Base: master ← Head: 1536-duplicate-tab

📝 Commits (9)

  • dc8f5c4 Implemented method to duplicate a tab
  • f4f186a Merge branch 'master' of github.com:microsoft/terminal into 1536-duplicate-tab
  • 2216768 Added event definitions for duplicating a tab with keyboard shortcut(CTRL + SHIFT + D)
  • 604f203 Cleanup in App.h and CascadiaSettings.cpp
  • f5035ad Merge branch 'master' of github.com:microsoft/terminal into 1536-duplicate-tab
  • b89676d Fixed declaration error in AppKeyBindings.cpp
  • 33647ac Using 'const' for variable delcaration
  • 0942345 Applied code-format
  • f21e3f5 Chnaged tabstops to 4 spaces for each tabstop

📊 Changes

7 files changed (+29 additions, -1 deletions)

View changed files

📝 src/cascadia/TerminalApp/App.cpp (+14 -0)
📝 src/cascadia/TerminalApp/App.h (+1 -0)
📝 src/cascadia/TerminalApp/AppKeyBindings.cpp (+5 -1)
📝 src/cascadia/TerminalApp/AppKeyBindings.h (+1 -0)
📝 src/cascadia/TerminalApp/AppKeyBindings.idl (+3 -0)
📝 src/cascadia/TerminalApp/AppKeyBindingsSerialization.cpp (+2 -0)
📝 src/cascadia/TerminalApp/CascadiaSettings.cpp (+3 -0)

📄 Description

Added keybinding option to duplicate focused tab

Summary of the Pull Request

Added necessary delcarations and implmentations to provide a new keybinding for duplicating the focused tab.

References

PR Checklist

  • Closes Why are my profile icons blurry (#1536)
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed N/A
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #1536

Detailed Description of the Pull Request / Additional comments

As discussed in this issue, a simple implementation for duplicating the focused tab was made by me.
I added the needed declarations for the new keybinding and added a method to duplicate the focused tab in App.cpp.

Validation Steps Performed

  • Add keybinding element to profiles.json
    • "command" : "duplicateTab"
    • "keys": [ "ctrl+shift+d" ]
  • Open Terminal
  • Verify other features and functionalities work as usual without unexpected behaviour
  • Use configured keybinding to validate the duplication of the focused tab

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/1685 **Author:** [@dnagl](https://github.com/dnagl) **Created:** 6/27/2019 **Status:** ✅ Merged **Merged:** 7/2/2019 **Merged by:** [@miniksa](https://github.com/miniksa) **Base:** `master` ← **Head:** `1536-duplicate-tab` --- ### 📝 Commits (9) - [`dc8f5c4`](https://github.com/microsoft/terminal/commit/dc8f5c4b2e91b0143435361bf6f1699024480140) Implemented method to duplicate a tab - [`f4f186a`](https://github.com/microsoft/terminal/commit/f4f186a292537cd7561411d9cbaddca9bd11426c) Merge branch 'master' of github.com:microsoft/terminal into 1536-duplicate-tab - [`2216768`](https://github.com/microsoft/terminal/commit/221676810bee6da8c73582c269f81f6ca89d9191) Added event definitions for duplicating a tab with keyboard shortcut(CTRL + SHIFT + D) - [`604f203`](https://github.com/microsoft/terminal/commit/604f203f2b06f1387fc4e71a7c02ad36ddda6e47) Cleanup in App.h and CascadiaSettings.cpp - [`f5035ad`](https://github.com/microsoft/terminal/commit/f5035ad2c169c4f793c34a20b95d580a14e85559) Merge branch 'master' of github.com:microsoft/terminal into 1536-duplicate-tab - [`b89676d`](https://github.com/microsoft/terminal/commit/b89676da330683a64efd9dcc43ed155dd085a07b) Fixed declaration error in AppKeyBindings.cpp - [`33647ac`](https://github.com/microsoft/terminal/commit/33647ac6ff36bb37d9ac3f668df246b6a94a57b4) Using 'const' for variable delcaration - [`0942345`](https://github.com/microsoft/terminal/commit/09423451709c57eda85fd192c0326ad7ea3e5825) Applied code-format - [`f21e3f5`](https://github.com/microsoft/terminal/commit/f21e3f562a1b7d9f56cec15039c9461e3712d16f) Chnaged tabstops to 4 spaces for each tabstop ### 📊 Changes **7 files changed** (+29 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/App.cpp` (+14 -0) 📝 `src/cascadia/TerminalApp/App.h` (+1 -0) 📝 `src/cascadia/TerminalApp/AppKeyBindings.cpp` (+5 -1) 📝 `src/cascadia/TerminalApp/AppKeyBindings.h` (+1 -0) 📝 `src/cascadia/TerminalApp/AppKeyBindings.idl` (+3 -0) 📝 `src/cascadia/TerminalApp/AppKeyBindingsSerialization.cpp` (+2 -0) 📝 `src/cascadia/TerminalApp/CascadiaSettings.cpp` (+3 -0) </details> ### 📄 Description Added keybinding option to duplicate focused tab ## Summary of the Pull Request Added necessary delcarations and implmentations to provide a new keybinding for duplicating the focused tab. ## References ## PR Checklist * [x] Closes #1536 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests <del>added/passed</del> N/A * [ ] Requires documentation to be updated * [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #1536 ## Detailed Description of the Pull Request / Additional comments As discussed in this issue, a simple implementation for duplicating the focused tab was made by me. I added the needed declarations for the new keybinding and added a method to duplicate the focused tab in `App.cpp`. ## Validation Steps Performed * Add keybinding element to `profiles.json` * `"command" : "duplicateTab"` * `"keys": [ "ctrl+shift+d" ]` * Open Terminal * Verify other features and functionalities work as usual without unexpected behaviour * Use configured keybinding to validate the duplication of the focused tab --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:04:30 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24636
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?