starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #1740] [CLOSED] #1708 - Feature Request - Keyboard zoom-level adjustment #24659

New Issue
Open
opened 2026-01-31 09:04:37 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:04:37 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/1740
Author: @dnagl
Created: 6/30/2019
Status: ❌ Closed

Base: master ← Head: 1708-keyboard-zoom

📝 Commits (4)

  • 4931cbf Implemented new KeyBindings for increasing and decreasing zoom
  • e78dbb2 Implemented method which can be used from other App.cpp class to modify the font-zoom level
  • 6d43c32 Changed KeyBinding
  • 0912ed1 Implemented methods for increasing and decreasing zoom level and linked them with keybindings

📊 Changes

10 files changed (+69 additions, -0 deletions)

View changed files

📝 src/cascadia/TerminalApp/App.cpp (+18 -0)
📝 src/cascadia/TerminalApp/App.h (+2 -0)
📝 src/cascadia/TerminalApp/AppKeyBindings.cpp (+8 -0)
📝 src/cascadia/TerminalApp/AppKeyBindings.h (+2 -0)
📝 src/cascadia/TerminalApp/AppKeyBindings.idl (+6 -0)
📝 src/cascadia/TerminalApp/AppKeyBindingsSerialization.cpp (+4 -0)
📝 src/cascadia/TerminalApp/CascadiaSettings.cpp (+6 -0)
📝 src/cascadia/TerminalControl/TermControl.cpp (+19 -0)
📝 src/cascadia/TerminalControl/TermControl.h (+2 -0)
📝 src/cascadia/TerminalControl/TermControl.idl (+2 -0)

📄 Description

Added keybinding option for increasing and decreasing the font size in a terminal

Summary of the Pull Request

Added implementation to allow users to increase and decrease the font size in a terminal.
This feature behaves like the user would turn the mouse-wheel one step up/down.

References

PR Checklist

  • Closes Unable to use backslash on any shell (#1708)
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed N/A
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #1708

Detailed Description of the Pull Request / Additional comments

A simple implementation for the functionality to 'zoom' in/out with CTRL pressed and using the wheel on the mouse was made.
Therefore I added the needed implementations for this, which can be seen in the diff to the master.

Validation Steps Performed

  • Open Terminal
  • Press CTRL + '+' -> Font size increases
  • Press CTRL + '-' -> Font size decreases

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/1740 **Author:** [@dnagl](https://github.com/dnagl) **Created:** 6/30/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `1708-keyboard-zoom` --- ### 📝 Commits (4) - [`4931cbf`](https://github.com/microsoft/terminal/commit/4931cbf4d7bbf499731d3e1a81a61341b64bbcaf) Implemented new KeyBindings for increasing and decreasing zoom - [`e78dbb2`](https://github.com/microsoft/terminal/commit/e78dbb23b40114c4f9959c22dc93b79769a8b604) Implemented method which can be used from other App.cpp class to modify the font-zoom level - [`6d43c32`](https://github.com/microsoft/terminal/commit/6d43c32c720bc7aed9e563171b5a7a962de4626d) Changed KeyBinding - [`0912ed1`](https://github.com/microsoft/terminal/commit/0912ed14100a3064d5f224af490f923bc57abdfe) Implemented methods for increasing and decreasing zoom level and linked them with keybindings ### 📊 Changes **10 files changed** (+69 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/App.cpp` (+18 -0) 📝 `src/cascadia/TerminalApp/App.h` (+2 -0) 📝 `src/cascadia/TerminalApp/AppKeyBindings.cpp` (+8 -0) 📝 `src/cascadia/TerminalApp/AppKeyBindings.h` (+2 -0) 📝 `src/cascadia/TerminalApp/AppKeyBindings.idl` (+6 -0) 📝 `src/cascadia/TerminalApp/AppKeyBindingsSerialization.cpp` (+4 -0) 📝 `src/cascadia/TerminalApp/CascadiaSettings.cpp` (+6 -0) 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+19 -0) 📝 `src/cascadia/TerminalControl/TermControl.h` (+2 -0) 📝 `src/cascadia/TerminalControl/TermControl.idl` (+2 -0) </details> ### 📄 Description Added keybinding option for increasing and decreasing the font size in a terminal ## Summary of the Pull Request Added implementation to allow users to increase and decrease the font size in a terminal. This feature behaves like the user would turn the mouse-wheel one step up/down. ## References ## PR Checklist * [x] Closes #1708 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests <del>added/passed</del> N/A * [ ] Requires documentation to be updated * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #1708 <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments A simple implementation for the functionality to 'zoom' in/out with CTRL pressed and using the wheel on the mouse was made. Therefore I added the needed implementations for this, which can be seen in the diff to the master. ## Validation Steps Performed * Open Terminal * Press CTRL + '+' -> Font size increases * Press CTRL + '-' -> Font size decreases --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:04:37 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24659
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?