starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #1808] [MERGED] The Azure cloud shell connector #24670

New Issue
Open
opened 2026-01-31 09:04:41 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:04:41 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/1808
Author: @PankajBhojwani
Created: 7/3/2019
Status: ✅ Merged
Merged: 7/25/2019
Merged by: @PankajBhojwani

Base: master ← Head: realAzCon

📝 Commits (10+)

  • e9ead80 App now initializes the connection instead of term control.
  • 091a4cb formatting changes
  • 4b4a984 Azure cloud shell connector #1235
  • 3c05858 Merge branch 'master' of https://github.com/microsoft/terminal into realAzCon
  • 10b7b57 split the dependency package into two, one for x86 one for x64
  • 8efcc87 made changes based on reviewer comments and made the dependency package smaller
  • ddb857d formatting changes
  • e41221f the package dependency is even smaller now
  • a810d69 package should work now
  • 5a031b9 1. Significant restructuring - it now behaves like a state machine; 2. The connector now has the ability to store tokens for future logins

📊 Changes

24 files changed (+1189 additions, -32 deletions)

View changed files

📝 src/cascadia/CascadiaPackage/CascadiaPackage.wapproj (+6 -3)
➕ src/cascadia/CascadiaPackage/ProfileIcons/{b453ae62-4e3d-5e58-b989-0a998ec441b8}.scale-100.png (+0 -0)
➕ src/cascadia/CascadiaPackage/ProfileIcons/{b453ae62-4e3d-5e58-b989-0a998ec441b8}.scale-200.png (+0 -0)
📝 src/cascadia/TerminalApp/App.cpp (+29 -12)
📝 src/cascadia/TerminalApp/App.h (+1 -0)
📝 src/cascadia/TerminalApp/CascadiaSettings.cpp (+16 -0)
📝 src/cascadia/TerminalApp/CascadiaSettings.h (+2 -0)
📝 src/cascadia/TerminalApp/Profile.cpp (+32 -0)
📝 src/cascadia/TerminalApp/Profile.h (+5 -0)
➕ src/cascadia/TerminalConnection/AzureClientID.h (+8 -0)
➕ src/cascadia/TerminalConnection/AzureConnection.cpp (+889 -0)
➕ src/cascadia/TerminalConnection/AzureConnection.h (+106 -0)
➕ src/cascadia/TerminalConnection/AzureConnection.idl (+13 -0)
➕ src/cascadia/TerminalConnection/AzureConnectionStrings.h (+30 -0)
📝 src/cascadia/TerminalConnection/ConhostConnection.cpp (+2 -5)
📝 src/cascadia/TerminalConnection/TerminalConnection.vcxproj (+21 -8)
📝 src/cascadia/TerminalConnection/TerminalConnection.vcxproj.filters (+7 -3)
📝 src/cascadia/TerminalConnection/packages.config (+1 -0)
📝 src/cascadia/TerminalConnection/pch.h (+5 -0)
📝 src/cascadia/TerminalCore/Terminal.cpp (+5 -0)

...and 4 more files

📄 Description

Implemented a new connection type, the Azure cloud shell connector

#1235

PR Checklist

  • Closes ConPTY should less aggressively reprint the screen (#1235)
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan.
  • Implemented a new connection
  • Created a new default profile for that connection (includes icons)
  • Added very basic handling for the backspace VT sequence
  • Added a condition to check for \a (aka the BEL character) just so we don't try to print that character

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/1808 **Author:** [@PankajBhojwani](https://github.com/PankajBhojwani) **Created:** 7/3/2019 **Status:** ✅ Merged **Merged:** 7/25/2019 **Merged by:** [@PankajBhojwani](https://github.com/PankajBhojwani) **Base:** `master` ← **Head:** `realAzCon` --- ### 📝 Commits (10+) - [`e9ead80`](https://github.com/microsoft/terminal/commit/e9ead80fd6883f54ef2b03b569f17ac4c6f8f4d3) App now initializes the connection instead of term control. - [`091a4cb`](https://github.com/microsoft/terminal/commit/091a4cb14e24f930ccf40b916736815dd7bd4801) formatting changes - [`4b4a984`](https://github.com/microsoft/terminal/commit/4b4a98458987191a950852400fcd8747a9f7377b) Azure cloud shell connector #1235 - [`3c05858`](https://github.com/microsoft/terminal/commit/3c05858618375f16b65cd12e6b3ff1881b8bdd4d) Merge branch 'master' of https://github.com/microsoft/terminal into realAzCon - [`10b7b57`](https://github.com/microsoft/terminal/commit/10b7b5705f9665e5cf9762b8a15789d6b02f49fa) split the dependency package into two, one for x86 one for x64 - [`8efcc87`](https://github.com/microsoft/terminal/commit/8efcc87546db8a7b93b2d970c5bd5a31ea7ac327) made changes based on reviewer comments and made the dependency package smaller - [`ddb857d`](https://github.com/microsoft/terminal/commit/ddb857d3c0f34aa6f95f1462c22d940d5f7c47f8) formatting changes - [`e41221f`](https://github.com/microsoft/terminal/commit/e41221f7c3142f12c3ec45f43acc8cb4e46b35c7) the package dependency is even smaller now - [`a810d69`](https://github.com/microsoft/terminal/commit/a810d6954d671f0ee28d61643ee2cd6ff7d49675) package should work now - [`5a031b9`](https://github.com/microsoft/terminal/commit/5a031b9eee67a3f350196df589f0e043ed5036c1) 1. Significant restructuring - it now behaves like a state machine; 2. The connector now has the ability to store tokens for future logins ### 📊 Changes **24 files changed** (+1189 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/CascadiaPackage/CascadiaPackage.wapproj` (+6 -3) ➕ `src/cascadia/CascadiaPackage/ProfileIcons/{b453ae62-4e3d-5e58-b989-0a998ec441b8}.scale-100.png` (+0 -0) ➕ `src/cascadia/CascadiaPackage/ProfileIcons/{b453ae62-4e3d-5e58-b989-0a998ec441b8}.scale-200.png` (+0 -0) 📝 `src/cascadia/TerminalApp/App.cpp` (+29 -12) 📝 `src/cascadia/TerminalApp/App.h` (+1 -0) 📝 `src/cascadia/TerminalApp/CascadiaSettings.cpp` (+16 -0) 📝 `src/cascadia/TerminalApp/CascadiaSettings.h` (+2 -0) 📝 `src/cascadia/TerminalApp/Profile.cpp` (+32 -0) 📝 `src/cascadia/TerminalApp/Profile.h` (+5 -0) ➕ `src/cascadia/TerminalConnection/AzureClientID.h` (+8 -0) ➕ `src/cascadia/TerminalConnection/AzureConnection.cpp` (+889 -0) ➕ `src/cascadia/TerminalConnection/AzureConnection.h` (+106 -0) ➕ `src/cascadia/TerminalConnection/AzureConnection.idl` (+13 -0) ➕ `src/cascadia/TerminalConnection/AzureConnectionStrings.h` (+30 -0) 📝 `src/cascadia/TerminalConnection/ConhostConnection.cpp` (+2 -5) 📝 `src/cascadia/TerminalConnection/TerminalConnection.vcxproj` (+21 -8) 📝 `src/cascadia/TerminalConnection/TerminalConnection.vcxproj.filters` (+7 -3) 📝 `src/cascadia/TerminalConnection/packages.config` (+1 -0) 📝 `src/cascadia/TerminalConnection/pch.h` (+5 -0) 📝 `src/cascadia/TerminalCore/Terminal.cpp` (+5 -0) _...and 4 more files_ </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> Implemented a new connection type, the Azure cloud shell connector <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> #1235 <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [X] Closes #1235 * [ ] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Requires documentation to be updated * [X] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> - Implemented a new connection - Created a new default profile for that connection (includes icons) - Added very basic handling for the backspace VT sequence - Added a condition to check for \a (aka the BEL character) just so we don't try to print that character --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:04:41 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24670
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?