starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #1887] [MERGED] Added links to user docs inside About popup #24686

New Issue
Open
opened 2026-01-31 09:04:46 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:04:46 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/1887
Author: @cinnamon-msft
Created: 7/9/2019
Status: ✅ Merged
Merged: 7/11/2019
Merged by: @undefined

Base: master ← Head: cinnamon/user-docs-link

📝 Commits (5)

  • 23c794e added links into about section
  • 41fff2a Merge branch 'master' into cinnamon/user-docs-link
  • bcf2901 added resources and aka.ms links
  • 27c5221 moved links to resources
  • 9c1e66e Move the feedback URI into the resources too!

📊 Changes

3 files changed (+101 additions, -32 deletions)

View changed files

📝 src/cascadia/CascadiaPackage/Resources/en-US/Resources.resw (+52 -28)
📝 src/cascadia/TerminalApp/App.cpp (+48 -4)
📝 src/cascadia/TerminalApp/pch.h (+1 -0)

📄 Description

Summary of the Pull Request

Added links to "Getting Started", "Documentation", and "Release Notes" in the About section.

References

#1576

PR Checklist

  • Closes Failed to build the terminal due to CL.exe under visual 2019 (#1576)
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

MicrosoftTeams-image (3)
MicrosoftTeams-image (4)

Validation Steps Performed

Clicked the links and they all work.

TODO

The hover color is too dark to read when using dark theme.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/1887 **Author:** [@cinnamon-msft](https://github.com/cinnamon-msft) **Created:** 7/9/2019 **Status:** ✅ Merged **Merged:** 7/11/2019 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `cinnamon/user-docs-link` --- ### 📝 Commits (5) - [`23c794e`](https://github.com/microsoft/terminal/commit/23c794ef971199c528cdf8259239f696620770b4) added links into about section - [`41fff2a`](https://github.com/microsoft/terminal/commit/41fff2a8792c4c48fa98a180bb089abc41ddf149) Merge branch 'master' into cinnamon/user-docs-link - [`bcf2901`](https://github.com/microsoft/terminal/commit/bcf29016acfddd168d1c004f71a434f11c1a00c2) added resources and aka.ms links - [`27c5221`](https://github.com/microsoft/terminal/commit/27c5221af6c13976db6108c635e55d8f1b0e4d5f) moved links to resources - [`9c1e66e`](https://github.com/microsoft/terminal/commit/9c1e66e403650de60f2faf7b835997f38e98c60e) Move the feedback URI into the resources too! ### 📊 Changes **3 files changed** (+101 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/CascadiaPackage/Resources/en-US/Resources.resw` (+52 -28) 📝 `src/cascadia/TerminalApp/App.cpp` (+48 -4) 📝 `src/cascadia/TerminalApp/pch.h` (+1 -0) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Added links to "[Getting Started](https://github.com/microsoft/terminal/blob/master/doc/user-docs/UsingJsonSettings.md)", "[Documentation](https://github.com/microsoft/terminal/blob/master/doc/user-docs/index.md)", and "[Release Notes](https://github.com/microsoft/terminal/releases)" in the About section. <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References #1576 <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #1576 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Requires documentation to be updated * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments ![MicrosoftTeams-image (3)](https://user-images.githubusercontent.com/48369326/60860262-995d3900-a1ca-11e9-91a9-8b8e71cd0f74.png) ![MicrosoftTeams-image (4)](https://user-images.githubusercontent.com/48369326/60860268-9c582980-a1ca-11e9-869b-1b0ddb64c243.png) <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed Clicked the links and they all work. ## TODO The hover color is too dark to read when using dark theme. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:04:46 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24686
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?