[PR #1879] Bugfix: selection on wide glyph in scrollback buffer #24692

Open
opened 2026-01-31 09:04:48 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/1879

State: closed
Merged: Yes


Summary of the Pull Request

I was accidentally looking at the mutable viewport instead of the buffer.

References

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

  1. Added wide glyph.
  2. dir
  3. scroll up
  4. select wide glyph
**Original Pull Request:** https://github.com/microsoft/terminal/pull/1879 **State:** closed **Merged:** Yes --- <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request I was accidentally looking at the mutable viewport instead of the buffer. <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #1549 * [ ] Tests added/passed <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed 1. Added wide glyph. 2. `dir` 3. scroll up 4. select wide glyph
claunia added the pull-request label 2026-01-31 09:04:48 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24692