starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #1900] [MERGED] Fix the WAP packaging project #24699

New Issue
Open
opened 2026-01-31 09:04:50 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:04:50 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/1900
Author: @DHowett-MSFT
Created: 7/10/2019
Status: ✅ Merged
Merged: 7/12/2019
Merged by: @DHowett-MSFT

Base: master ← Head: dev/duhowett/fixwap

📝 Commits (3)

  • 0be3224 Fix the WAP packaging project
  • 68ab678 Apply a couple more fixes to the WAP project
  • 70e987c Update src/cascadia/TerminalApp/TerminalApp.vcxproj

📊 Changes

5 files changed (+54 additions, -31 deletions)

View changed files

📝 src/cascadia/CascadiaPackage/CascadiaPackage.wapproj (+26 -16)
📝 src/cascadia/TerminalApp/MinMaxCloseControl.cpp (+1 -2)
📝 src/cascadia/TerminalApp/TerminalApp.vcxproj (+26 -0)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+1 -4)
📝 src/cascadia/WindowsTerminal/WindowsTerminal.vcxproj (+0 -9)

📄 Description

This commits fixes the centennial package by:

  • Forcing XBF (XAML binary format) files to be embedded in project
    PRI files.
  • Moving package content generation to before PRI generation
  • Collecting all of the package's PRI files to merge into resources.pri
  • Fixing the hardcoded resource paths to reflect the new reality.

It also includes a magic value that fixes the bug where the project is
autodetected as a Mixed (CLR + Native) project.

Fixes #1816.

PR Checklist

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/1900 **Author:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Created:** 7/10/2019 **Status:** ✅ Merged **Merged:** 7/12/2019 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `dev/duhowett/fixwap` --- ### 📝 Commits (3) - [`0be3224`](https://github.com/microsoft/terminal/commit/0be3224f41f14be5a34fd47adb174c0c6a5a3bc6) Fix the WAP packaging project - [`68ab678`](https://github.com/microsoft/terminal/commit/68ab67867a84bc4e93310435569414713f181a8a) Apply a couple more fixes to the WAP project - [`70e987c`](https://github.com/microsoft/terminal/commit/70e987c7b248b76c0590b26d88bbe6665aa8938e) Update src/cascadia/TerminalApp/TerminalApp.vcxproj ### 📊 Changes **5 files changed** (+54 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/CascadiaPackage/CascadiaPackage.wapproj` (+26 -16) 📝 `src/cascadia/TerminalApp/MinMaxCloseControl.cpp` (+1 -2) 📝 `src/cascadia/TerminalApp/TerminalApp.vcxproj` (+26 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+1 -4) 📝 `src/cascadia/WindowsTerminal/WindowsTerminal.vcxproj` (+0 -9) </details> ### 📄 Description This commits fixes the centennial package by: * Forcing XBF (XAML binary format) files to be embedded in project PRI files. * Moving package content generation to before PRI generation * Collecting all of the package's PRI files to merge into resources.pri * Fixing the hardcoded resource paths to reflect the new reality. It also includes a magic value that fixes the bug where the project is autodetected as a Mixed (CLR + Native) project. Fixes #1816. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #1816 * [x] CLA signed * [x] Tests added/passed/na? * [x] Requires documentation to be updated/na? * [x] I've discussed this with core contributors already. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:04:50 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24699
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?