starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #1901] Add Vintage color scheme to defaults; fixes #1781 #24701

New Issue
Open
opened 2026-01-31 09:04:50 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:04:50 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/microsoft/terminal/pull/1901

State: closed
Merged: Yes

This change adds the "Classic" color scheme to the ones in the default profiles.json settings file, with the colors suggested by @ocalvo in issue #1781. I named it "Vintage" per @DHowett-MSFT's suggestion.

PR Checklist

  • Closes Feature Request: Double height + legacy block drawing characters. (#1781)
  • CLA signed - N/A; I work for Microsoft
  • Tests added/passed - N/A; see discussion below
  • Requires documentation to be updated - N/A; no doc update required
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan.

Validation Steps Performed

All manual tests. I didn't feel it was necessary to add any automated tests because the only ones that would make sense would be ones to check that other default color schemes aren't regressed, and we don't have any tests for default settings today (presumably because they change too often!).

  • Deleted profiles.json, started Terminal.
  • Verified that the output "Vintage" color scheme existed in the newly created profiles.json file.
  • Verified that "Vintage" diffed equal to the "Classic" scheme in the issue, apart from the name and the addition of "background" and "foreground" colors, which I made equal to the "black" and "white" ones respectively.
  • Verified that I could set a profile to use Vintage and that the colors changed accordingly.
**Original Pull Request:** https://github.com/microsoft/terminal/pull/1901 **State:** closed **Merged:** Yes --- This change adds the "Classic" color scheme to the ones in [the default `profiles.json` settings file](https://github.com/microsoft/terminal/blob/122f0de382542de14d79babad92699d916057783/doc/user-docs/UsingJsonSettings.md), with the colors suggested by @ocalvo in issue #1781. I named it "Vintage" per @DHowett-MSFT's suggestion. ### PR Checklist * [x] Closes #1781 * [x] CLA signed - N/A; I work for Microsoft * [ ] Tests added/passed - N/A; see discussion below * [x] Requires documentation to be updated - N/A; no doc update required * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. ### Validation Steps Performed All manual tests. I didn't feel it was necessary to add any automated tests because the only ones that would make sense would be ones to check that other default color schemes aren't regressed, and we don't have any tests for default settings today (presumably because they change too often!). - Deleted `profiles.json`, started Terminal. - Verified that the output "Vintage" color scheme existed in the newly created `profiles.json` file. - Verified that "Vintage" diffed equal to the "Classic" scheme in the issue, apart from the name and the addition of "background" and "foreground" colors, which I made equal to the "black" and "white" ones respectively. - Verified that I could set a profile to use Vintage and that the colors changed accordingly.
claunia added the pull-request label 2026-01-31 09:04:50 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24701
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?