starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #1929] [MERGED] Set utf-8 for the entire project #24715

New Issue
Open
opened 2026-01-31 09:04:56 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:04:56 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/1929
Author: @miniksa
Created: 7/11/2019
Status: ✅ Merged
Merged: 7/11/2019
Merged by: @miniksa

Base: master ← Head: dev/miniksa/utf8

📝 Commits (2)

  • d0060e3 Set utf-8 for the entire project. Re-encode UnicodeLiteral.hpp file as UTF-8.
  • 3c10c4e OK this isn't even used anymore. Torch it.

📊 Changes

3 files changed (+1 additions, -7 deletions)

View changed files

📝 src/common.build.pre.props (+1 -1)
📝 src/host/ut_host/ClipboardTests.cpp (+0 -1)
➖ src/host/ut_host/UnicodeLiteral.hpp (+0 -5)

📄 Description

Summary of the Pull Request

There were a few issues when we first opened the project related to building in other locales because we weren't using UTF-8.

References

#458
#549
I will close those because this supersedes them.

PR Checklist

  • Closes assorted build issues for people who are fortunate enough to live in places that aren't 'MURICA.
  • CLA not signed but I work at Microsoft so I've already signed away my life.
  • Tests should still pass. I'll let the CI tell me.
  • Doesn't require docs.
  • Hi, it's me. It's my project. You all live in my world.

Detailed Description of the Pull Request / Additional comments

I set the /utf-8 flag globally in the pre props file per the commentary in #458. I also converted the one complaining file UnicodeLiterals.hpp to UTF-8 without a BOM to get it to stop complaining.

I have a personal vendetta against BOMs so I'm wholesale rejecting the idea of #549. Microsoft was wrong to BOM. If I had a time machine, I would go egg the person on the .NET team at Microsoft who decided to BOM everything a long time ago and keep going back in time to egg them repeatedly until I felt satisfaction for the pain they've caused me in my life because Microsoft UTF-8 stuff is BOM'd.

Validation Steps Performed

  • I built it and it's fine.
  • The CI will build it and it will hopefully be fine.
  • I built it in Windows with true Razzle and it's fine.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/1929 **Author:** [@miniksa](https://github.com/miniksa) **Created:** 7/11/2019 **Status:** ✅ Merged **Merged:** 7/11/2019 **Merged by:** [@miniksa](https://github.com/miniksa) **Base:** `master` ← **Head:** `dev/miniksa/utf8` --- ### 📝 Commits (2) - [`d0060e3`](https://github.com/microsoft/terminal/commit/d0060e3aeaf271a023e5bc037b199c016817bab5) Set utf-8 for the entire project. Re-encode UnicodeLiteral.hpp file as UTF-8. - [`3c10c4e`](https://github.com/microsoft/terminal/commit/3c10c4e2d0d9159bd4511d692b8cbc8bc59a82d3) OK this isn't even used anymore. Torch it. ### 📊 Changes **3 files changed** (+1 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/common.build.pre.props` (+1 -1) 📝 `src/host/ut_host/ClipboardTests.cpp` (+0 -1) ➖ `src/host/ut_host/UnicodeLiteral.hpp` (+0 -5) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request There were a few issues when we first opened the project related to building in other locales because we weren't using UTF-8. <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References #458 #549 I will close those because this supersedes them. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes assorted build issues for people who are fortunate enough to live in places that aren't 'MURICA. * [x] CLA not signed but I work at Microsoft so I've already signed away my life. * [x] Tests should still pass. I'll let the CI tell me. * [x] Doesn't require docs. * [x] Hi, it's me. It's my project. You all live in my world. <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments I set the /utf-8 flag globally in the pre props file per the commentary in #458. I also converted the one complaining file `UnicodeLiterals.hpp` to UTF-8 without a BOM to get it to stop complaining. I have a personal vendetta against BOMs so I'm wholesale rejecting the idea of #549. Microsoft was wrong to BOM. If I had a time machine, I would go egg the person on the .NET team at Microsoft who decided to BOM everything a long time ago and keep going back in time to egg them repeatedly until I felt satisfaction for the pain they've caused me in my life because Microsoft UTF-8 stuff is BOM'd. <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed - I built it and it's fine. - The CI will build it and it will hopefully be fine. - I built it in Windows with true Razzle and it's fine. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:04:56 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24715
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?