[PR #1972] [MERGED] Move TerminalApp's resources into the TerminalApp project #24735

Open
opened 2026-01-31 09:05:04 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/1972
Author: @DHowett-MSFT
Created: 7/15/2019
Status: Merged
Merged: 7/23/2019
Merged by: @DHowett-MSFT

Base: masterHead: dev/duhowett/resources


📝 Commits (5)

  • e9127c9 Move TerminalApp's resources into the TerminalApp project
  • 497afc0 Merge remote-tracking branch 'github/master' into dev/duhowett/resources
  • 5b1d0f8 ResourceAccessor->ScopedResourceLoader
  • 66229d5 I mean well don't be silly
  • 70b8739 Apply suggestions from code review

📊 Changes

8 files changed (+251 additions, -65 deletions)

View changed files

📝 src/cascadia/CascadiaPackage/Resources/en-US/Resources.resw (+0 -45)
📝 src/cascadia/TerminalApp/App.cpp (+18 -19)
📝 src/cascadia/TerminalApp/App.h (+3 -0)
src/cascadia/TerminalApp/Resources/en-US/Resources.resw (+174 -0)
src/cascadia/TerminalApp/ScopedResourceLoader.cpp (+37 -0)
src/cascadia/TerminalApp/ScopedResourceLoader.h (+16 -0)
📝 src/cascadia/TerminalApp/lib/TerminalAppLib.vcxproj (+2 -0)
📝 src/cascadia/TerminalApp/lib/pch.h (+1 -1)

📄 Description

This commit also introduces a scoped resource accessor, lightly taken
from microsoft-ui-xaml. It also moves all static UI strings out of
App.cpp and into localizable resources.

Fixes #792. Puts us in a better place to address #1484.

The resource accessor was necessary to make sure that TerminalApp loaded its own resources and not the toplevel resource dictionary.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/1972 **Author:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Created:** 7/15/2019 **Status:** ✅ Merged **Merged:** 7/23/2019 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `dev/duhowett/resources` --- ### 📝 Commits (5) - [`e9127c9`](https://github.com/microsoft/terminal/commit/e9127c9d14429e6fffefa117d7e3a34a42b9a34e) Move TerminalApp's resources into the TerminalApp project - [`497afc0`](https://github.com/microsoft/terminal/commit/497afc0489e476cec9ec546a056d72a37fba0d01) Merge remote-tracking branch 'github/master' into dev/duhowett/resources - [`5b1d0f8`](https://github.com/microsoft/terminal/commit/5b1d0f88e6acfd918a701b095d3135439263d815) ResourceAccessor->ScopedResourceLoader - [`66229d5`](https://github.com/microsoft/terminal/commit/66229d50bb48dbde2cdf06ebe954edd72a98daac) I mean well don't be _silly_ - [`70b8739`](https://github.com/microsoft/terminal/commit/70b87399d53148c2da40f75d8e2599202750f03c) Apply suggestions from code review ### 📊 Changes **8 files changed** (+251 additions, -65 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/CascadiaPackage/Resources/en-US/Resources.resw` (+0 -45) 📝 `src/cascadia/TerminalApp/App.cpp` (+18 -19) 📝 `src/cascadia/TerminalApp/App.h` (+3 -0) ➕ `src/cascadia/TerminalApp/Resources/en-US/Resources.resw` (+174 -0) ➕ `src/cascadia/TerminalApp/ScopedResourceLoader.cpp` (+37 -0) ➕ `src/cascadia/TerminalApp/ScopedResourceLoader.h` (+16 -0) 📝 `src/cascadia/TerminalApp/lib/TerminalAppLib.vcxproj` (+2 -0) 📝 `src/cascadia/TerminalApp/lib/pch.h` (+1 -1) </details> ### 📄 Description This commit also introduces a scoped resource accessor, lightly taken from microsoft-ui-xaml. It also moves all static UI strings out of App.cpp and into localizable resources. Fixes #792. Puts us in a better place to address #1484. The resource accessor was necessary to make sure that TerminalApp loaded its own resources and not the toplevel resource dictionary. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:05:04 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24735