starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #1981] [CLOSED] Added Escape Key to CharacterHandler so it can be handled instead of returned. #24746

New Issue
Open
opened 2026-01-31 09:05:08 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:05:08 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/1981
Author: @ghost
Created: 7/15/2019
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (10+)

  • 616bd1e Merge pull request #1 from microsoft/master
  • 017f57f Added Escape key to CharacterHandler and made the neccecary adjustments.
  • 426f8bb Fixed formatting issues to pass formatting check.
  • 8062fb7 Fixed compilation issue
  • 1246f0c Fixed compilation issues
  • 5746984 Merge branch 'master' into master
  • 11239bb Fixed formatting and merged changes
  • ea8d629 Fixed compilation error
  • a0782bf Mark ESC as handled so that it doesn't come back in CharacterHandler (#1974)
  • ba4d4a0 Added Escape key to CharacterHandler and made the neccecary adjustments.

📊 Changes

18 files changed (+57 additions, -67 deletions)

View changed files

📝 samples/ConPTY/MiniTerm/MiniTerm/Terminal.cs (+1 -1)
📝 src/cascadia/TerminalConnection/ConhostConnection.cpp (+1 -1)
📝 src/cascadia/TerminalConnection/ConptyConnection.cpp (+1 -1)
📝 src/cascadia/TerminalCore/Terminal.cpp (+8 -1)
📝 src/host/cmdline.h (+1 -1)
📝 src/host/ft_host/API_InputTests.cpp (+1 -1)
📝 src/host/ft_uia/AccessibilityTests.cs (+3 -3)
📝 src/inc/unicode.hpp (+1 -0)
📝 src/interactivity/onecore/ConIoSrvComm.cpp (+19 -22)
📝 src/server/ApiSorter.cpp (+2 -5)
📝 src/server/IoDispatchers.cpp (+5 -11)
📝 src/server/WaitQueue.cpp (+2 -2)
📝 src/terminal/adapter/MouseInput.cpp (+5 -8)
📝 src/tools/nihilist/main.cpp (+1 -1)
📝 src/tools/vtapp/Program.cs (+1 -1)
📝 src/tools/vtapp/Program2.cs (+1 -1)
📝 src/tools/vtpipeterm/VtConsole.cpp (+1 -1)
📝 src/tsf/TfEditses.cpp (+3 -6)

📄 Description

Summary of the Pull Request

References

PR Checklist

  • [x ] Closes ##1295
  • [ x] CLA signed. If not, go over here and sign the CLA
  • [x ] Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Simply, the escape key is not handled, and it should be, as well as adjustments for more clear and maintainable code.

Validation Steps Performed

-Manual testing to ensure no test errors.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/1981 **Author:** [@ghost](https://github.com/ghost) **Created:** 7/15/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`616bd1e`](https://github.com/microsoft/terminal/commit/616bd1ee66b5a5aaf7f1a4358a66162b55ee8079) Merge pull request #1 from microsoft/master - [`017f57f`](https://github.com/microsoft/terminal/commit/017f57fa27f5725248594d12a4a7b7a79bd0e605) Added Escape key to CharacterHandler and made the neccecary adjustments. - [`426f8bb`](https://github.com/microsoft/terminal/commit/426f8bb04d0a2c6053f42e665d1cf1090b750435) Fixed formatting issues to pass formatting check. - [`8062fb7`](https://github.com/microsoft/terminal/commit/8062fb7384e999467c86c86d84d9a677be1324cf) Fixed compilation issue - [`1246f0c`](https://github.com/microsoft/terminal/commit/1246f0c635e68dec430f1027aa990178f068b85e) Fixed compilation issues - [`5746984`](https://github.com/microsoft/terminal/commit/5746984cb2366c71534fa9ea1e3bcc20309963d7) Merge branch 'master' into master - [`11239bb`](https://github.com/microsoft/terminal/commit/11239bb799cb499186489c8d37f27c6e1bc0c960) Fixed formatting and merged changes - [`ea8d629`](https://github.com/microsoft/terminal/commit/ea8d62905027b8ddae18ad976589692033c9ce50) Fixed compilation error - [`a0782bf`](https://github.com/microsoft/terminal/commit/a0782bfd6c319f20ea11939e29c91692c571c452) Mark ESC as handled so that it doesn't come back in CharacterHandler (#1974) - [`ba4d4a0`](https://github.com/microsoft/terminal/commit/ba4d4a0c104ebb83052b43c5f0406bce46f5f09a) Added Escape key to CharacterHandler and made the neccecary adjustments. ### 📊 Changes **18 files changed** (+57 additions, -67 deletions) <details> <summary>View changed files</summary> 📝 `samples/ConPTY/MiniTerm/MiniTerm/Terminal.cs` (+1 -1) 📝 `src/cascadia/TerminalConnection/ConhostConnection.cpp` (+1 -1) 📝 `src/cascadia/TerminalConnection/ConptyConnection.cpp` (+1 -1) 📝 `src/cascadia/TerminalCore/Terminal.cpp` (+8 -1) 📝 `src/host/cmdline.h` (+1 -1) 📝 `src/host/ft_host/API_InputTests.cpp` (+1 -1) 📝 `src/host/ft_uia/AccessibilityTests.cs` (+3 -3) 📝 `src/inc/unicode.hpp` (+1 -0) 📝 `src/interactivity/onecore/ConIoSrvComm.cpp` (+19 -22) 📝 `src/server/ApiSorter.cpp` (+2 -5) 📝 `src/server/IoDispatchers.cpp` (+5 -11) 📝 `src/server/WaitQueue.cpp` (+2 -2) 📝 `src/terminal/adapter/MouseInput.cpp` (+5 -8) 📝 `src/tools/nihilist/main.cpp` (+1 -1) 📝 `src/tools/vtapp/Program.cs` (+1 -1) 📝 `src/tools/vtapp/Program2.cs` (+1 -1) 📝 `src/tools/vtpipeterm/VtConsole.cpp` (+1 -1) 📝 `src/tsf/TfEditses.cpp` (+3 -6) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x ] Closes ##1295 * [ x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [x ] Tests added/passed * [ ] Requires documentation to be updated * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments Simply, the escape key is not handled, and it should be, as well as adjustments for more clear and maintainable code. <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed -Manual testing to ensure no test errors. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:05:08 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24746
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?