starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #1995] Rework a whole bunch of build stuff #24749

New Issue
Open
opened 2026-01-31 09:05:08 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:05:08 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/microsoft/terminal/pull/1995

State: closed
Merged: No

This draft pull request contains a number of interesting changes. Let's talk about the results first.

  • All dependencies can be removed from WindowsTerminal except TerminalApp
  • All normal-build xcopy rules have been removed
  • All project build output (including the MSIX) goes in /obj and /bin.
  • Almost all build configuration between cppwinrt and non-cppwinrt projects has been unified (#1155)
  • TerminalApp no longer needs to manually include TerminalAppLib's stuff
    • It can use a normal ProjectReference
  • The package works.
  • CascadiaPackage no longer needs to include nuget packages itself
  • The application is still double-click activatable
  • PRI files are automatically rolled up
  • The package is 17MB because it includes TerminalAppLib.lib (👎)

Now, the how:

  • WindowsTerminal now defines GetPackagingOutputs, which recurses into its children (just like an appx project)
  • cppwinrt.build.pre.props now defers to common.build.pre.props for most of its configuration (and loses a bunch of redundant configuration)
  • OutDir is set before including the C++ machinery (this turned out to be important (!))
  • CascadiaPackage has been given a nudge towards including all subproject packaging outputs

This will still not work properly on Visual Studio 16.3, pending a fix for TerminalAppLib/TerminalApp that @zadjii-msft is cooking up.

**Original Pull Request:** https://github.com/microsoft/terminal/pull/1995 **State:** closed **Merged:** No --- This _draft_ pull request contains a number of interesting changes. Let's talk about the _results_ first. * All dependencies can be removed from WindowsTerminal except TerminalApp * All normal-build xcopy rules have been removed * All project build output (including the MSIX) goes in `/obj` and `/bin`. * Almost all build configuration between cppwinrt and non-cppwinrt projects has been unified (#1155) * TerminalApp no longer needs to manually include TerminalAppLib's stuff * It _can_ use a normal ProjectReference * The package works. * CascadiaPackage no longer needs to include nuget packages itself * The application is still double-click activatable * PRI files are automatically rolled up * The package is 17MB because it includes TerminalAppLib.lib (👎) Now, the how: * WindowsTerminal now defines `GetPackagingOutputs`, which recurses into its children (just like an appx project) * `cppwinrt.build.pre.props` now defers to `common.build.pre.props` for most of its configuration (and loses a bunch of redundant configuration) * `OutDir` is set _before_ including the C++ machinery (this turned out to be important (!)) * CascadiaPackage has been given a nudge towards including all subproject packaging outputs This will still not work properly on Visual Studio 16.3, pending a fix for TerminalAppLib/TerminalApp that @zadjii-msft is cooking up.
claunia added the pull-request label 2026-01-31 09:05:08 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24749
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?