[PR #1981] Added Escape Key to CharacterHandler so it can be handled instead of returned. #24751

Open
opened 2026-01-31 09:05:09 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/1981

State: closed
Merged: No


Summary of the Pull Request

References

PR Checklist

  • [x ] Closes ##1295
  • [ x] CLA signed. If not, go over here and sign the CLA
  • [x ] Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Simply, the escape key is not handled, and it should be, as well as adjustments for more clear and maintainable code.

Validation Steps Performed

-Manual testing to ensure no test errors.

**Original Pull Request:** https://github.com/microsoft/terminal/pull/1981 **State:** closed **Merged:** No --- <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x ] Closes ##1295 * [ x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [x ] Tests added/passed * [ ] Requires documentation to be updated * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments Simply, the escape key is not handled, and it should be, as well as adjustments for more clear and maintainable code. <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed -Manual testing to ensure no test errors.
claunia added the pull-request label 2026-01-31 09:05:09 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24751