[PR #2012] [MERGED] Add a keybinding for ClosePane #24756

Open
opened 2026-01-31 09:05:11 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/2012
Author: @zadjii-msft
Created: 7/17/2019
Status: ✅ Merged
Merged: 7/19/2019
Merged by: @carlos-zamora

Base: master ← Head: dev/migrie/f/993-but-on-master-this-time


📝 Commits (1)

  • 27e8d00 Add a keybinding for ClosePane

📊 Changes

11 files changed (+55 additions, -2 deletions)

View changed files

📝 src/cascadia/TerminalApp/App.cpp (+12 -0)
📝 src/cascadia/TerminalApp/App.h (+1 -0)
📝 src/cascadia/TerminalApp/AppKeyBindings.cpp (+4 -0)
📝 src/cascadia/TerminalApp/AppKeyBindings.h (+1 -0)
📝 src/cascadia/TerminalApp/AppKeyBindings.idl (+3 -0)
📝 src/cascadia/TerminalApp/AppKeyBindingsSerialization.cpp (+2 -0)
📝 src/cascadia/TerminalApp/CascadiaSettings.cpp (+2 -2)
📝 src/cascadia/TerminalApp/Pane.cpp (+12 -0)
📝 src/cascadia/TerminalApp/Pane.h (+2 -0)
📝 src/cascadia/TerminalApp/Tab.cpp (+14 -0)
📝 src/cascadia/TerminalApp/Tab.h (+2 -0)

📄 Description

Summary of the Pull Request

Closes #993
When the last pane in a tab is closed, the tab will close.
Bound to Ctrl+Shift+W by default.

References

See #1417 for discussion on the default keybindings. The Ctrl+W->CloseTab keybinding is being removed in favor ClosePane.

PR Checklist


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/2012 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 7/17/2019 **Status:** ✅ Merged **Merged:** 7/19/2019 **Merged by:** [@carlos-zamora](https://github.com/carlos-zamora) **Base:** `master` ← **Head:** `dev/migrie/f/993-but-on-master-this-time` --- ### 📝 Commits (1) - [`27e8d00`](https://github.com/microsoft/terminal/commit/27e8d008f90abb2bba4dbf66dfc7f71ba92ccdf8) Add a keybinding for ClosePane ### 📊 Changes **11 files changed** (+55 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/App.cpp` (+12 -0) 📝 `src/cascadia/TerminalApp/App.h` (+1 -0) 📝 `src/cascadia/TerminalApp/AppKeyBindings.cpp` (+4 -0) 📝 `src/cascadia/TerminalApp/AppKeyBindings.h` (+1 -0) 📝 `src/cascadia/TerminalApp/AppKeyBindings.idl` (+3 -0) 📝 `src/cascadia/TerminalApp/AppKeyBindingsSerialization.cpp` (+2 -0) 📝 `src/cascadia/TerminalApp/CascadiaSettings.cpp` (+2 -2) 📝 `src/cascadia/TerminalApp/Pane.cpp` (+12 -0) 📝 `src/cascadia/TerminalApp/Pane.h` (+2 -0) 📝 `src/cascadia/TerminalApp/Tab.cpp` (+14 -0) 📝 `src/cascadia/TerminalApp/Tab.h` (+2 -0) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Closes #993 When the last pane in a tab is closed, the tab will close. Bound to Ctrl+Shift+W by default. <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References See #1417 for discussion on the default keybindings. The Ctrl+W->CloseTab keybinding is being removed in favor ClosePane. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #993 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [N/A] Requires documentation to be updated * [X] I work here --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:05:11 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24756