starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #2067] [MERGED] Allow the mapping of OEM keys ({}|\<>/_-=+) in key bindings #24785

New Issue
Open
opened 2026-01-31 09:05:20 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:05:20 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/2067
Author: @DHowett-MSFT
Created: 7/23/2019
Status: ✅ Merged
Merged: 7/23/2019
Merged by: @DHowett-MSFT

Base: master ← Head: dev/duhowett/oemvk

📝 Commits (2)

  • 5531286 Allow the mapping of OEM keys ({}|<>/_-=+) in key bindings
  • 8bb5332 Update src/cascadia/TerminalApp/App.cpp

📊 Changes

4 files changed (+65 additions, -45 deletions)

View changed files

📝 src/cascadia/TerminalApp/App.cpp (+35 -2)
📝 src/cascadia/TerminalApp/AppKeyBindings.cpp (+0 -27)
📝 src/cascadia/TerminalApp/AppKeyBindings.h (+0 -1)
📝 src/cascadia/TerminalApp/KeyChordSerialization.cpp (+30 -15)

📄 Description

This commit introduces support for key bindings containing keys
traditionally classified as "OEM" keys. It uses VkKeyScanW and
MapVirtualKeyW, and translates the modifiers that come out of
VkKeyScanW to key chord modifiers.

The net result of this is that you can use bindings like "ctrl+|" in
your settings. That one in particular will be reserialized (and
displayed in any menus) as "ctrl+shift+". Admittedly, this is not
clear, but it is the truest representation of the key.

This commit also moves the Xaml key chord name override generator into
App as a static function, AND it forces its use for all modifier
names. This will present a localization issue, which will be helped in
part by #1972. This is required to work around
microsoft/microsoft-ui-xaml#708. I've kept the original code around
guarded by a puzzling ifdef, because it absolutely has value.

Fixes #1212.

image

Renormalization

input reserialized as
"alt+=" "alt+plus"
"alt+:" "alt+shift+;"
"ctrl+?" "ctrl+shift+/"
"shift+~" "shift+<backtick>"
(markdown limitation)
"alt+}" "alt+shift+]"
"ctrl+alt+<pipe>" "ctrl+alt+shift+\\"
"shift+\"" "shift+'"
"alt+," "alt+,"
"ctrl+-" "ctrl+-"
"shift+." "shift+."

PR Checklist

Validation Steps Performed

Manual

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/2067 **Author:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Created:** 7/23/2019 **Status:** ✅ Merged **Merged:** 7/23/2019 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `dev/duhowett/oemvk` --- ### 📝 Commits (2) - [`5531286`](https://github.com/microsoft/terminal/commit/5531286b85ba8ed21fefba559dbd2acc4008f9af) Allow the mapping of OEM keys ({}|\<>/_-=+) in key bindings - [`8bb5332`](https://github.com/microsoft/terminal/commit/8bb5332578d92cd0389276c1746d61ab1361911c) Update src/cascadia/TerminalApp/App.cpp ### 📊 Changes **4 files changed** (+65 additions, -45 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/App.cpp` (+35 -2) 📝 `src/cascadia/TerminalApp/AppKeyBindings.cpp` (+0 -27) 📝 `src/cascadia/TerminalApp/AppKeyBindings.h` (+0 -1) 📝 `src/cascadia/TerminalApp/KeyChordSerialization.cpp` (+30 -15) </details> ### 📄 Description This commit introduces support for key bindings containing keys traditionally classified as "OEM" keys. It uses VkKeyScanW and MapVirtualKeyW, and translates the modifiers that come out of VkKeyScanW to key chord modifiers. The net result of this is that you can use bindings like "ctrl+|" in your settings. That one in particular will be reserialized (and displayed in any menus) as "ctrl+shift+\". Admittedly, this is not clear, but it _is_ the truest representation of the key. This commit also moves the Xaml key chord name override generator into App as a static function, *AND* it forces its use for all modifier names. This will present a localization issue, which will be helped in part by #1972. This is required to work around microsoft/microsoft-ui-xaml#708. I've kept the original code around guarded by a puzzling ifdef, because it absolutely has value. Fixes #1212. ![image](https://user-images.githubusercontent.com/14316954/61683890-22489a00-accc-11e9-8fa2-88869043ac4a.png) ### Renormalization | input | reserialized as | |-|-| | `"alt+="` | `"alt+plus"` | | `"alt+:"` | `"alt+shift+;"` | | `"ctrl+?"` | `"ctrl+shift+/"` | | `"shift+~"` | `"shift+<backtick>"`<br>_(markdown limitation)_ | | `"alt+}"` | `"alt+shift+]"` | | `"ctrl+alt+<pipe>"` | `"ctrl+alt+shift+\\"` | | `"shift+\""` | `"shift+'"` | | `"alt+,"` | `"alt+,"` | | `"ctrl+-"` | `"ctrl+-"` | | `"shift+."` | `"shift+."` | <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #1212 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [x] I've discussed this with core contributors already. ## Validation Steps Performed Manual --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:05:20 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24785
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?