[PR #2118] [MERGED] Prevent a crash on resizing too small caused by the Titlebar #24816

Open
opened 2026-01-31 09:05:31 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/2118
Author: @zadjii-msft
Created: 7/26/2019
Status: ✅ Merged
Merged: 7/26/2019
Merged by: @zadjii-msft

Base: master ← Head: dev/migrie/b/2045-titlebar-too-smol


📝 Commits (1)

  • d39817d Prevent a crash on resizing too small caused by the Titlebar

📊 Changes

1 file changed (+8 additions, -2 deletions)

View changed files

📝 src/cascadia/TerminalApp/TitlebarControl.cpp (+8 -2)

📄 Description

Summary of the Pull Request

Only set the MaxWidth of the TitlebarControl's Content when the value is
positive. Any smaller will crash the app.

PR Checklist

Validation Steps Performed

Opened the terminal with this fix and just went wild on the resize


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/2118 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 7/26/2019 **Status:** ✅ Merged **Merged:** 7/26/2019 **Merged by:** [@zadjii-msft](https://github.com/zadjii-msft) **Base:** `master` ← **Head:** `dev/migrie/b/2045-titlebar-too-smol` --- ### 📝 Commits (1) - [`d39817d`](https://github.com/microsoft/terminal/commit/d39817d54db89ca807d0890ad5d51634e8f39f2b) Prevent a crash on resizing too small caused by the Titlebar ### 📊 Changes **1 file changed** (+8 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/TitlebarControl.cpp` (+8 -2) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Only set the MaxWidth of the TitlebarControl's Content when the value is positive. Any smaller will crash the app. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #2045 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [n/a] Tests added/passed * [x] I've discussed this with core contributors already. <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed Opened the terminal with this fix and just went wild on the resize --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:05:31 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24816