starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #2207] [CLOSED] Add initial extensions handling via optional packages #24854

New Issue
Open
opened 2026-01-31 09:05:46 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:05:46 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/2207
Author: @twsouthwick
Created: 8/3/2019
Status: ❌ Closed

Base: master ← Head: extensions

📝 Commits (2)

  • 2e9683a Add initial extensions handling via optional packages
  • 4ed7d01 Merge remote-tracking branch 'upstream/master' into extensions

📊 Changes

53 files changed (+1120 additions, -183 deletions)

View changed files

📝 OpenConsole.sln (+48 -0)
➕ src/cascadia/CascadiaPackage/Bundle.mapping.txt (+2 -0)
📝 src/cascadia/CascadiaPackage/CascadiaPackage.wapproj (+5 -2)
➕ src/cascadia/Plugins/Terminal.Plugin.AzureCloudShell.App/App.xaml (+7 -0)
➕ src/cascadia/Plugins/Terminal.Plugin.AzureCloudShell.App/App.xaml.cpp (+115 -0)
➕ src/cascadia/Plugins/Terminal.Plugin.AzureCloudShell.App/App.xaml.h (+27 -0)
➕ src/cascadia/Plugins/Terminal.Plugin.AzureCloudShell.App/Assets/LockScreenLogo.scale-200.png (+0 -0)
➕ src/cascadia/Plugins/Terminal.Plugin.AzureCloudShell.App/Assets/SplashScreen.scale-200.png (+0 -0)
➕ src/cascadia/Plugins/Terminal.Plugin.AzureCloudShell.App/Assets/Square150x150Logo.scale-200.png (+0 -0)
➕ src/cascadia/Plugins/Terminal.Plugin.AzureCloudShell.App/Assets/Square44x44Logo.scale-200.png (+0 -0)
➕ src/cascadia/Plugins/Terminal.Plugin.AzureCloudShell.App/Assets/Square44x44Logo.targetsize-24_altform-unplated.png (+0 -0)
➕ src/cascadia/Plugins/Terminal.Plugin.AzureCloudShell.App/Assets/StoreLogo.png (+0 -0)
➕ src/cascadia/Plugins/Terminal.Plugin.AzureCloudShell.App/Assets/Wide310x150Logo.scale-200.png (+0 -0)
➕ src/cascadia/Plugins/Terminal.Plugin.AzureCloudShell.App/MainPage.xaml (+14 -0)
➕ src/cascadia/Plugins/Terminal.Plugin.AzureCloudShell.App/MainPage.xaml.cpp (+27 -0)
➕ src/cascadia/Plugins/Terminal.Plugin.AzureCloudShell.App/MainPage.xaml.h (+21 -0)
➕ src/cascadia/Plugins/Terminal.Plugin.AzureCloudShell.App/Package.appxmanifest (+48 -0)
➕ src/cascadia/Plugins/Terminal.Plugin.AzureCloudShell.App/Terminal.Plugin.AzureCloudShell.App.vcxproj (+106 -0)
➕ src/cascadia/Plugins/Terminal.Plugin.AzureCloudShell.App/Terminal.Plugin.AzureCloudShell.App.vcxproj.filters (+50 -0)
➕ src/cascadia/Plugins/Terminal.Plugin.AzureCloudShell.App/pch.cpp (+5 -0)

...and 33 more files

📄 Description

Summary of the Pull Request

This adds extension support via optional packages, including moving the Azure connector to such a package. This does not enable 3rd party plugins (optional packages run as the same identity and in the same process), but provides some infrastructure that could be helpful for 3rd part plugins as well.

References

#555

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

This adds a few interfaces to allow composing of sources for terminal connections and moves the Azure connection source to its own library that is brought in via an optional package. The interfaces added are:

  • ITerminalConnectionProvider: This can retrieve a connection factory by id and enumerate available factories
  • ITerminalConnectionFactory: This provides information of an available connection as well as allows for creation of an instance
  • TerminalConnectionStartupInfo: A class that contains information as to the initial start up state of a connection

A default AppConnectionProvider provides an implementation of ITerminalConnectionProvider that searches any optional packages and loads them via an exported function GetConnectionProvider that returns an ITerminalConnectionProvider. This could be expanded to include providers for all the default profiles so that nothing is hard coded but retrieved through a provider.

A caveat to loading optional packages is that the package must be signed by a valid certificate (can be a local dev), but without that it will fail. An error is written to the debug window to help diagnose that issue if it is encountered.

Validation Steps Performted

I did a variety of manual testing. The plugin is only available when the package is deployed, so I tried various permutations of running without, with, then without. If the plugin is removed, I've just had it load the EchoConnection since I wasn't sure if there was a better way of handling errors but I didn't want it to crash.

Feel free to say no if you have other plans to enable this, but if there's interest I'll respond to feedback.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/2207 **Author:** [@twsouthwick](https://github.com/twsouthwick) **Created:** 8/3/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `extensions` --- ### 📝 Commits (2) - [`2e9683a`](https://github.com/microsoft/terminal/commit/2e9683a9ae771b6a9654810c3f83317d812c2330) Add initial extensions handling via optional packages - [`4ed7d01`](https://github.com/microsoft/terminal/commit/4ed7d01dad41659f5abaafc07f7d45acc249651e) Merge remote-tracking branch 'upstream/master' into extensions ### 📊 Changes **53 files changed** (+1120 additions, -183 deletions) <details> <summary>View changed files</summary> 📝 `OpenConsole.sln` (+48 -0) ➕ `src/cascadia/CascadiaPackage/Bundle.mapping.txt` (+2 -0) 📝 `src/cascadia/CascadiaPackage/CascadiaPackage.wapproj` (+5 -2) ➕ `src/cascadia/Plugins/Terminal.Plugin.AzureCloudShell.App/App.xaml` (+7 -0) ➕ `src/cascadia/Plugins/Terminal.Plugin.AzureCloudShell.App/App.xaml.cpp` (+115 -0) ➕ `src/cascadia/Plugins/Terminal.Plugin.AzureCloudShell.App/App.xaml.h` (+27 -0) ➕ `src/cascadia/Plugins/Terminal.Plugin.AzureCloudShell.App/Assets/LockScreenLogo.scale-200.png` (+0 -0) ➕ `src/cascadia/Plugins/Terminal.Plugin.AzureCloudShell.App/Assets/SplashScreen.scale-200.png` (+0 -0) ➕ `src/cascadia/Plugins/Terminal.Plugin.AzureCloudShell.App/Assets/Square150x150Logo.scale-200.png` (+0 -0) ➕ `src/cascadia/Plugins/Terminal.Plugin.AzureCloudShell.App/Assets/Square44x44Logo.scale-200.png` (+0 -0) ➕ `src/cascadia/Plugins/Terminal.Plugin.AzureCloudShell.App/Assets/Square44x44Logo.targetsize-24_altform-unplated.png` (+0 -0) ➕ `src/cascadia/Plugins/Terminal.Plugin.AzureCloudShell.App/Assets/StoreLogo.png` (+0 -0) ➕ `src/cascadia/Plugins/Terminal.Plugin.AzureCloudShell.App/Assets/Wide310x150Logo.scale-200.png` (+0 -0) ➕ `src/cascadia/Plugins/Terminal.Plugin.AzureCloudShell.App/MainPage.xaml` (+14 -0) ➕ `src/cascadia/Plugins/Terminal.Plugin.AzureCloudShell.App/MainPage.xaml.cpp` (+27 -0) ➕ `src/cascadia/Plugins/Terminal.Plugin.AzureCloudShell.App/MainPage.xaml.h` (+21 -0) ➕ `src/cascadia/Plugins/Terminal.Plugin.AzureCloudShell.App/Package.appxmanifest` (+48 -0) ➕ `src/cascadia/Plugins/Terminal.Plugin.AzureCloudShell.App/Terminal.Plugin.AzureCloudShell.App.vcxproj` (+106 -0) ➕ `src/cascadia/Plugins/Terminal.Plugin.AzureCloudShell.App/Terminal.Plugin.AzureCloudShell.App.vcxproj.filters` (+50 -0) ➕ `src/cascadia/Plugins/Terminal.Plugin.AzureCloudShell.App/pch.cpp` (+5 -0) _...and 33 more files_ </details> ### 📄 Description ## Summary of the Pull Request This adds extension support via optional packages, including moving the Azure connector to such a package. This does not enable 3rd party plugins (optional packages run as the same identity and in the same process), but provides some infrastructure that could be helpful for 3rd part plugins as well. ## References #555 ## PR Checklist * [ ] Closes #xxx * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Requires documentation to be updated * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx ## Detailed Description of the Pull Request / Additional comments This adds a few interfaces to allow composing of sources for terminal connections and moves the Azure connection source to its own library that is brought in via an optional package. The interfaces added are: - ITerminalConnectionProvider: This can retrieve a connection factory by id and enumerate available factories - ITerminalConnectionFactory: This provides information of an available connection as well as allows for creation of an instance - TerminalConnectionStartupInfo: A class that contains information as to the initial start up state of a connection A default `AppConnectionProvider` provides an implementation of `ITerminalConnectionProvider` that searches any optional packages and loads them via an exported function `GetConnectionProvider` that returns an `ITerminalConnectionProvider`. This could be expanded to include providers for all the default profiles so that nothing is hard coded but retrieved through a provider. A caveat to loading optional packages is that the package must be signed by a valid certificate (can be a local dev), but without that it will fail. An error is written to the debug window to help diagnose that issue if it is encountered. ## Validation Steps Performted I did a variety of manual testing. The plugin is only available when the package is deployed, so I tried various permutations of running without, with, then without. If the plugin is removed, I've just had it load the EchoConnection since I wasn't sure if there was a better way of handling errors but I didn't want it to crash. Feel free to say no if you have other plans to enable this, but if there's interest I'll respond to feedback. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:05:46 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24854
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?