[PR #2298] Stop Roaming settings #24887

Open
opened 2026-01-31 09:05:55 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/2298

State: closed
Merged: Yes


Summary of the Pull Request

We'll no longer use RoamingState as our app data folder. Instead we'll use the LocalState folder. This will prevent settings from automatically roaming.

We'll also MoveFile existing settings from RoamingState to LocalState, if we find it in RoamingState, but not LocalState.

PR Checklist

Validation Steps Performed

  • No profiles.json -> generates a new one in LocalState
  • Profile in LocalState, not Roaming -> Nothing happens, loads normally.
  • Profile in RoamingState, not Local -> File moves to Local, loads normally.
  • profile in both -> File in Roaming is ignored, only uses Local, loads normally.
**Original Pull Request:** https://github.com/microsoft/terminal/pull/2298 **State:** closed **Merged:** Yes --- <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request We'll no longer use RoamingState as our app data folder. Instead we'll use the LocalState folder. This will prevent settings from automatically roaming. We'll also `MoveFile` existing settings from RoamingState to LocalState, if we find it in RoamingState, but not LocalState. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #1770 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [?] Requires documentation to be updated * [x] I've discussed this with core contributors already. <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed * No profiles.json -> generates a new one in LocalState * Profile in LocalState, not Roaming -> Nothing happens, loads normally. * Profile in RoamingState, not Local -> File moves to Local, loads normally. * profile in _both_ -> File in Roaming is ignored, only uses Local, loads normally.
claunia added the pull-request label 2026-01-31 09:05:55 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24887