starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #2365] [MERGED] Add default keybinding for opening dropdown #24895

New Issue
Open
opened 2026-01-31 09:05:58 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:05:58 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/2365
Author: @cinnamon-msft
Created: 8/8/2019
Status: ✅ Merged
Merged: 8/16/2019
Merged by: @undefined

Base: master ← Head: cinnamon/dropdown-keybinding

📝 Commits (8)

  • f8199de added keybinding for opening dropdown
  • 03ad19a fixed spacing issues
  • 8647b46 tabs spaces sadness fix
  • 3c66f63 code formatting
  • 4c7e9f7 Merge remote-tracking branch 'origin' into cinnamon/dropdown-keybinding
  • bf37a9c renamed references to openNewTabDropdown and updated documentation
  • 8a03d85 removed newline
  • 8b3e755 Merge branch 'master' into cinnamon/dropdown-keybinding

📊 Changes

8 files changed (+29 additions, -0 deletions)

View changed files

📝 doc/cascadia/SettingsSchema.md (+1 -0)
📝 src/cascadia/TerminalApp/App.cpp (+12 -0)
📝 src/cascadia/TerminalApp/App.h (+1 -0)
📝 src/cascadia/TerminalApp/AppKeyBindings.cpp (+4 -0)
📝 src/cascadia/TerminalApp/AppKeyBindings.h (+1 -0)
📝 src/cascadia/TerminalApp/AppKeyBindings.idl (+3 -0)
📝 src/cascadia/TerminalApp/AppKeyBindingsSerialization.cpp (+2 -0)
📝 src/cascadia/TerminalApp/CascadiaSettings.cpp (+5 -0)

📄 Description

Summary of the Pull Request

Adds default keybinding of CtrlShiftSpace to open the dropdown menu.

References

PR Checklist

  • Closes Settings open Visual Studio 2017 (#2181)
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

CtrlShiftSpace will not close the dropdown menu if it has been opened. Do we want this functionality or is ESC sufficient?

Validation Steps Performed

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/2365 **Author:** [@cinnamon-msft](https://github.com/cinnamon-msft) **Created:** 8/8/2019 **Status:** ✅ Merged **Merged:** 8/16/2019 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `cinnamon/dropdown-keybinding` --- ### 📝 Commits (8) - [`f8199de`](https://github.com/microsoft/terminal/commit/f8199de6eb98b0271e6dc117261725e7d54ca116) added keybinding for opening dropdown - [`03ad19a`](https://github.com/microsoft/terminal/commit/03ad19a9e5fad6b9d69d49bd1cf589a844fceafa) fixed spacing issues - [`8647b46`](https://github.com/microsoft/terminal/commit/8647b46d6344f95d667fca73f59499ed9462901f) tabs spaces sadness fix - [`3c66f63`](https://github.com/microsoft/terminal/commit/3c66f6385da5bdbccf51d6bb0406f6297faecd41) code formatting - [`4c7e9f7`](https://github.com/microsoft/terminal/commit/4c7e9f75cf2b6d6866e7701ad8c2863c9585c0b7) Merge remote-tracking branch 'origin' into cinnamon/dropdown-keybinding - [`bf37a9c`](https://github.com/microsoft/terminal/commit/bf37a9cbf4f5ca3d60c8a2f0f3e562fe79cdc4c0) renamed references to openNewTabDropdown and updated documentation - [`8a03d85`](https://github.com/microsoft/terminal/commit/8a03d8515c71356adb74a29ee1ff0bb31e057d54) removed newline - [`8b3e755`](https://github.com/microsoft/terminal/commit/8b3e7556dd96f686510349cd36831d93b1de7d37) Merge branch 'master' into cinnamon/dropdown-keybinding ### 📊 Changes **8 files changed** (+29 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/SettingsSchema.md` (+1 -0) 📝 `src/cascadia/TerminalApp/App.cpp` (+12 -0) 📝 `src/cascadia/TerminalApp/App.h` (+1 -0) 📝 `src/cascadia/TerminalApp/AppKeyBindings.cpp` (+4 -0) 📝 `src/cascadia/TerminalApp/AppKeyBindings.h` (+1 -0) 📝 `src/cascadia/TerminalApp/AppKeyBindings.idl` (+3 -0) 📝 `src/cascadia/TerminalApp/AppKeyBindingsSerialization.cpp` (+2 -0) 📝 `src/cascadia/TerminalApp/CascadiaSettings.cpp` (+5 -0) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Adds default keybinding of <kbd>Ctrl</kbd><kbd>Shift</kbd><kbd>Space</kbd> to open the dropdown menu. <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #2181 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [x] Requires documentation to be updated * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <kbd>Ctrl</kbd><kbd>Shift</kbd><kbd>Space</kbd> will not close the dropdown menu if it has been opened. Do we want this functionality or is <kbd>ESC</kbd> sufficient? <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:05:58 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24895
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?