[PR #2376] [MERGED] Only update the icon of a tab it the icon actually _changed_ #24904

Open
opened 2026-01-31 09:06:02 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/2376
Author: @zadjii-msft
Created: 8/9/2019
Status: Merged
Merged: 8/15/2019
Merged by: @DHowett-MSFT

Base: masterHead: dev/migrie/b/1333-icon-flashing


📝 Commits (4)

  • b94c767 Only update the icon of a tab it the icon actually changed
  • 5083493 Make Profile::GetIcon always expand env vars
  • b255078 Move this to a helper to make Dustin happy
  • 396fa52 Make this actually catch the exception, and clean it up a bit.

📊 Changes

7 files changed (+74 additions, -37 deletions)

View changed files

📝 src/cascadia/TerminalApp/App.cpp (+12 -31)
📝 src/cascadia/TerminalApp/Profile.cpp (+10 -5)
📝 src/cascadia/TerminalApp/Profile.h (+1 -1)
📝 src/cascadia/TerminalApp/Tab.cpp (+16 -0)
📝 src/cascadia/TerminalApp/Tab.h (+3 -0)
📝 src/cascadia/TerminalApp/Utils.cpp (+30 -0)
📝 src/cascadia/TerminalApp/Utils.h (+2 -0)

📄 Description

Summary of the Pull Request

Only update the icon of a tab it the icon actually changed. The way we have it, we'll try and update the icon everytime focus changes, causing the tab icon to blink for a second, even when switching between two panes with the same profile.

References

While I was here, I also fixed #2329, I think accidentally. But that's cool!

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/2376 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 8/9/2019 **Status:** ✅ Merged **Merged:** 8/15/2019 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `dev/migrie/b/1333-icon-flashing` --- ### 📝 Commits (4) - [`b94c767`](https://github.com/microsoft/terminal/commit/b94c767e07f93cebdd3b05a761b7e56d7f72f1ae) Only update the icon of a tab it the icon actually _changed_ - [`5083493`](https://github.com/microsoft/terminal/commit/5083493e61dc3b2739f86a078fa7a05f95c51988) Make Profile::GetIcon always expand env vars - [`b255078`](https://github.com/microsoft/terminal/commit/b25507833c3f512653e4776d73e2902be578dba1) Move this to a helper to make Dustin happy - [`396fa52`](https://github.com/microsoft/terminal/commit/396fa52a01ec70341c5654335c95d5f4e7fd8374) Make this actually catch the exception, and clean it up a bit. ### 📊 Changes **7 files changed** (+74 additions, -37 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/App.cpp` (+12 -31) 📝 `src/cascadia/TerminalApp/Profile.cpp` (+10 -5) 📝 `src/cascadia/TerminalApp/Profile.h` (+1 -1) 📝 `src/cascadia/TerminalApp/Tab.cpp` (+16 -0) 📝 `src/cascadia/TerminalApp/Tab.h` (+3 -0) 📝 `src/cascadia/TerminalApp/Utils.cpp` (+30 -0) 📝 `src/cascadia/TerminalApp/Utils.h` (+2 -0) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Only update the icon of a tab it the icon actually _changed_. The way we have it, we'll try and update the icon everytime focus changes, causing the tab icon to blink for a second, even when switching between two panes with the same profile. <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References While I was here, I also fixed #2329, I think accidentally. But that's cool! <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] fixes #1333 * [x] Also tangentially fixes #2329 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed (please review #2294 so I can start checking this box) <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:06:02 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24904