[PR #2438] [MERGED] When the titlebar is clicked, dismiss the new tab flyout #24931

Open
opened 2026-01-31 09:06:11 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/2438
Author: @zadjii-msft
Created: 8/15/2019
Status: Merged
Merged: 8/16/2019
Merged by: @undefined

Base: masterHead: dev/migrie/b/2028-titlebar-flyout


📝 Commits (2)

  • 2fc6cd4 When the titlebar is clicked, dismiss the new tab flyout
  • c068d21 Fix this for the base IslandWindow as well

📊 Changes

9 files changed (+68 additions, -10 deletions)

View changed files

📝 src/cascadia/TerminalApp/App.cpp (+17 -0)
📝 src/cascadia/TerminalApp/App.h (+1 -0)
📝 src/cascadia/TerminalApp/App.idl (+2 -0)
📝 src/cascadia/WindowsTerminal/AppHost.cpp (+5 -0)
📝 src/cascadia/WindowsTerminal/IslandWindow.cpp (+17 -0)
📝 src/cascadia/WindowsTerminal/IslandWindow.h (+3 -0)
📝 src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp (+21 -8)
📝 src/cascadia/WindowsTerminal/NonClientIslandWindow.h (+1 -1)
📝 src/cascadia/inc/cppwinrt_utils.h (+1 -1)

📄 Description

Summary of the Pull Request

  • Add a method to App to indicate to the app that the titlebar has been clicked. We'll use this method to Hide the flyout.
  • In NonClientIslandWindow, treat the titlebar as HTNOWHERE, so we get clicks in that area.
  • In NonClientIslandWindow, raise an event when the titlebar area is clicked. Also do the normal HTCAPTION thing we were doing before.
  • In AppHost, when it handles the event from NonClientIslandWindow, it'll call the method on App to close the flyout.

PR Checklist


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/2438 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 8/15/2019 **Status:** ✅ Merged **Merged:** 8/16/2019 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/migrie/b/2028-titlebar-flyout` --- ### 📝 Commits (2) - [`2fc6cd4`](https://github.com/microsoft/terminal/commit/2fc6cd4d402e047ab8282cc3feaff55bb157f2a4) When the titlebar is clicked, dismiss the new tab flyout - [`c068d21`](https://github.com/microsoft/terminal/commit/c068d21ecb622699ca705e655a6c9f9939809131) Fix this for the base IslandWindow as well ### 📊 Changes **9 files changed** (+68 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/App.cpp` (+17 -0) 📝 `src/cascadia/TerminalApp/App.h` (+1 -0) 📝 `src/cascadia/TerminalApp/App.idl` (+2 -0) 📝 `src/cascadia/WindowsTerminal/AppHost.cpp` (+5 -0) 📝 `src/cascadia/WindowsTerminal/IslandWindow.cpp` (+17 -0) 📝 `src/cascadia/WindowsTerminal/IslandWindow.h` (+3 -0) 📝 `src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp` (+21 -8) 📝 `src/cascadia/WindowsTerminal/NonClientIslandWindow.h` (+1 -1) 📝 `src/cascadia/inc/cppwinrt_utils.h` (+1 -1) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request * Add a method to `App` to indicate to the app that the titlebar has been clicked. We'll use this method to `Hide` the flyout. * In `NonClientIslandWindow`, treat the titlebar as `HTNOWHERE`, so we get clicks in that area. * In `NonClientIslandWindow`, raise an event when the titlebar area is clicked. Also do the normal `HTCAPTION` thing we were doing before. * In `AppHost`, when it handles the event from `NonClientIslandWindow`, it'll call the method on `App` to close the flyout. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #2028 * [N/A] Tests added/passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:06:11 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24931