starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #2475] [MERGED] Just never save the settings #24944

New Issue
Open
opened 2026-01-31 09:06:18 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:06:18 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/2475
Author: @zadjii-msft
Created: 8/19/2019
Status: ✅ Merged
Merged: 8/20/2019
Merged by: @carlos-zamora

Base: master ← Head: dev/migrie/f/just-never-save-settings

📝 Commits (1)

  • a92a3b7 Just never save the settings

📊 Changes

4 files changed (+7 additions, -30 deletions)

View changed files

📝 src/cascadia/TerminalApp/App.cpp (+4 -8)
📝 src/cascadia/TerminalApp/App.h (+1 -1)
📝 src/cascadia/TerminalApp/CascadiaSettings.h (+1 -1)
📝 src/cascadia/TerminalApp/CascadiaSettingsSerialization.cpp (+1 -20)

📄 Description

Summary of the Pull Request

This is more trouble than it's worth. We had code before to re-serialize settings when they changed, to try and gracefully migrate settings from old schemas to new ones. This is good in theory, but with #754 coming soon, this is going to become a minefield. In the future we'll just always be providing a base schema that's reasonable, so this won't matter so much. Keys that users have that aren't understood will just be ignored, and that's fine.

Related Issues

PR Checklist

  • Related to #754.
  • I've discussed this with core contributors already.

Validation Steps Performed

I tried changing "acrylicOpacity" to 0.9. When re-serialized, 0.9 becomes 0.8999grabage. This would have caused a re-format before, but no longer does :)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/2475 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 8/19/2019 **Status:** ✅ Merged **Merged:** 8/20/2019 **Merged by:** [@carlos-zamora](https://github.com/carlos-zamora) **Base:** `master` ← **Head:** `dev/migrie/f/just-never-save-settings` --- ### 📝 Commits (1) - [`a92a3b7`](https://github.com/microsoft/terminal/commit/a92a3b7b3b8e4a39a138e82019b8c4845962ab7d) Just never save the settings ### 📊 Changes **4 files changed** (+7 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/App.cpp` (+4 -8) 📝 `src/cascadia/TerminalApp/App.h` (+1 -1) 📝 `src/cascadia/TerminalApp/CascadiaSettings.h` (+1 -1) 📝 `src/cascadia/TerminalApp/CascadiaSettingsSerialization.cpp` (+1 -20) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request This is more trouble than it's worth. We had code before to re-serialize settings when they changed, to try and gracefully migrate settings from old schemas to new ones. This is good in theory, but with #754 coming soon, this is going to become a minefield. In the future we'll just always be providing a base schema that's reasonable, so this won't matter so much. Keys that users have that aren't understood will just be ignored, and that's _fine_. ### Related Issues * #2389 * #754 <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Related to #754. * [x] I've discussed this with core contributors already. <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed I tried changing `"acrylicOpacity"` to `0.9`. When re-serialized, `0.9` becomes `0.8999grabage`. This would have caused a re-format before, but no longer does :) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:06:18 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24944
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?