[PR #2544] [MERGED] Add some logging around startup, connection start timing #24985

Open
opened 2026-01-31 09:06:33 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/2544
Author: @zadjii-msft
Created: 8/26/2019
Status: ✅ Merged
Merged: 9/5/2019
Merged by: @zadjii-msft

Base: master ← Head: dev/migrie/f/some-timing


📝 Commits (10+)

  • 56c66d9 I thought this would work but it doesn't?
  • c7677b0 Merge branch 'master' into dev/migrie/f/some-timing
  • 285fe4b Actually register the tracelogging provider
  • aaaedbe Add a duration to the ConhostConnection
  • 3846a54 Add a duration to the settings load
  • 5cea152 Use the session GUID to track the length of a connection's startup
  • 86ebe96 Merge remote-tracking branch 'origin/master' into dev/migrie/f/some-timing
  • cfa4f78 Merge remote-tracking branch 'origin/master' into dev/migrie/f/some-timing
  • 480bdd7 Use high resolution time
  • 76b15a8 Merge remote-tracking branch 'origin/master' into dev/migrie/f/some-timing

📊 Changes

10 files changed (+117 additions, -6 deletions)

View changed files

📝 src/cascadia/TerminalApp/App.cpp (+20 -0)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+11 -6)
📝 src/cascadia/TerminalConnection/ConhostConnection.cpp (+17 -0)
📝 src/cascadia/TerminalConnection/ConhostConnection.h (+2 -0)
📝 src/cascadia/TerminalConnection/TerminalConnection.vcxproj (+1 -0)
➕ src/cascadia/TerminalConnection/init.cpp (+31 -0)
📝 src/cascadia/TerminalConnection/pch.h (+4 -0)
📝 src/cascadia/WindowsTerminal/AppHost.cpp (+7 -0)
📝 src/cascadia/WindowsTerminal/main.cpp (+17 -0)
📝 src/cascadia/WindowsTerminal/pch.h (+7 -0)

📄 Description

Summary of the Pull Request

Adds a number of TL events we can use to track startup time better. Adds events for:

  • Initial exe start
  • Time the window is created
  • time we start loading settings
  • time we finish loading setings
  • time when a connection recieves its first byte

Also updates our ConnectionCreated event to include the session GUID, so that we can correlate that with the connection's RecievedFirstByte event.

PR Checklist

Also @bitcrazed because I know he's been wanting this forever


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/2544 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 8/26/2019 **Status:** ✅ Merged **Merged:** 9/5/2019 **Merged by:** [@zadjii-msft](https://github.com/zadjii-msft) **Base:** `master` ← **Head:** `dev/migrie/f/some-timing` --- ### 📝 Commits (10+) - [`56c66d9`](https://github.com/microsoft/terminal/commit/56c66d97fe669671f64cc131fcc5fe87e19af6ab) I thought this would work but it doesn't? - [`c7677b0`](https://github.com/microsoft/terminal/commit/c7677b0b6414723bd983ba8e9037311b5cc12c6b) Merge branch 'master' into dev/migrie/f/some-timing - [`285fe4b`](https://github.com/microsoft/terminal/commit/285fe4bafc4bdfa5fffd9994b2ab7d89f8b91ead) Actually _register_ the tracelogging provider - [`aaaedbe`](https://github.com/microsoft/terminal/commit/aaaedbe837c682c03a9add97f97cea88f37a709d) Add a duration to the ConhostConnection - [`3846a54`](https://github.com/microsoft/terminal/commit/3846a541656187a1d367ddd49acf7d9c6622d979) Add a duration to the settings load - [`5cea152`](https://github.com/microsoft/terminal/commit/5cea152c134cbcca224eab432fdf796bdc0214c3) Use the session GUID to track the length of a connection's startup - [`86ebe96`](https://github.com/microsoft/terminal/commit/86ebe96a3ac60a149fda0486533087d06a17364e) Merge remote-tracking branch 'origin/master' into dev/migrie/f/some-timing - [`cfa4f78`](https://github.com/microsoft/terminal/commit/cfa4f78acf0f0d63bbfa09eac831f87519c68189) Merge remote-tracking branch 'origin/master' into dev/migrie/f/some-timing - [`480bdd7`](https://github.com/microsoft/terminal/commit/480bdd721f6909e4e9946af45749e5cdb64e3904) Use high resolution time - [`76b15a8`](https://github.com/microsoft/terminal/commit/76b15a80549f1e15aa84bacd92850d5431b25f3b) Merge remote-tracking branch 'origin/master' into dev/migrie/f/some-timing ### 📊 Changes **10 files changed** (+117 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/App.cpp` (+20 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+11 -6) 📝 `src/cascadia/TerminalConnection/ConhostConnection.cpp` (+17 -0) 📝 `src/cascadia/TerminalConnection/ConhostConnection.h` (+2 -0) 📝 `src/cascadia/TerminalConnection/TerminalConnection.vcxproj` (+1 -0) ➕ `src/cascadia/TerminalConnection/init.cpp` (+31 -0) 📝 `src/cascadia/TerminalConnection/pch.h` (+4 -0) 📝 `src/cascadia/WindowsTerminal/AppHost.cpp` (+7 -0) 📝 `src/cascadia/WindowsTerminal/main.cpp` (+17 -0) 📝 `src/cascadia/WindowsTerminal/pch.h` (+7 -0) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Adds a number of TL events we can use to track startup time better. Adds events for: * Initial exe start * Time the window is created * time we start loading settings * time we finish loading setings * time when a connection recieves its first byte Also updates our `ConnectionCreated` event to include the session GUID, so that we can correlate that with the connection's `RecievedFirstByte` event. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #2521 * [x] I work here * [ ] Tests added/passed - N/A * [x] Requires documentation to be updated * [x] I've discussed this with core contributors already. Also @bitcrazed because I know he's been wanting this forever --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:06:33 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#24985