starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #2609] [MERGED] Improve Accessibility Reliability #25013

New Issue
Open
opened 2026-01-31 09:06:42 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:06:42 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/2609
Author: @carlos-zamora
Created: 8/29/2019
Status: ✅ Merged
Merged: 9/23/2019
Merged by: @carlos-zamora

Base: master ← Head: dev/cazamor/acc/remove-WUP

📝 Commits (3)

  • 74b243f Remove WindowUiaProvider entry points
  • 9ffe519 code format
  • 8f0fe3a prefer universal initialization

📊 Changes

4 files changed (+31 additions, -4 deletions)

View changed files

📝 src/cascadia/TerminalControl/TermControl.cpp (+9 -3)
📝 src/cascadia/WindowsTerminal/BaseWindow.h (+11 -0)
📝 src/cascadia/WindowsTerminal/IslandWindow.cpp (+10 -0)
📝 src/cascadia/WindowsTerminal/IslandWindow.h (+1 -1)

📄 Description

Summary of the Pull Request

Remove WindowUiaProvider entry points
Make TerminalAutomationPeer not crash the app if creation failed.

References

PR Checklist

  • Closes nothing
  • CLA signed.
  • Tests added/passed
  • Requires documentation to be updated
  • I'm a core contributor

Detailed Description of the Pull Request / Additional comments

WindowUiaProvider was something I thought we needed. We still need it for signaling (maybe). But it sometimes can crash because it's not hooked up properly at all. For now, I removed all entry points. After the signaling model gets added for #2447, I'll decide if we actually need to remove it.

Also surrounded the TerminalControlAutomationPeer with a try/catch. If we don't have everything we need to create the AutomationPeer yet, we'll just catch it and move forward.

Validation Steps Performed

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/2609 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 8/29/2019 **Status:** ✅ Merged **Merged:** 9/23/2019 **Merged by:** [@carlos-zamora](https://github.com/carlos-zamora) **Base:** `master` ← **Head:** `dev/cazamor/acc/remove-WUP` --- ### 📝 Commits (3) - [`74b243f`](https://github.com/microsoft/terminal/commit/74b243fe8501f37847ab3da91f027da539e5abef) Remove WindowUiaProvider entry points - [`9ffe519`](https://github.com/microsoft/terminal/commit/9ffe5197464064742dd236b85a6cfc59ab618455) code format - [`8f0fe3a`](https://github.com/microsoft/terminal/commit/8f0fe3a2d013455b783d97ab3a52789bbbb2bfab) prefer universal initialization ### 📊 Changes **4 files changed** (+31 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+9 -3) 📝 `src/cascadia/WindowsTerminal/BaseWindow.h` (+11 -0) 📝 `src/cascadia/WindowsTerminal/IslandWindow.cpp` (+10 -0) 📝 `src/cascadia/WindowsTerminal/IslandWindow.h` (+1 -1) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Remove WindowUiaProvider entry points Make TerminalAutomationPeer not crash the app if creation failed. <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes nothing * [x] CLA signed. * [x] ~Tests added/passed~ * [x] ~Requires documentation to be updated~ * [x] I'm a core contributor <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments WindowUiaProvider was something I thought we needed. We still need it for signaling (maybe). But it sometimes can crash because it's not hooked up properly at all. For now, I removed all entry points. After the signaling model gets added for #2447, I'll decide if we actually need to remove it. Also surrounded the TerminalControlAutomationPeer with a try/catch. If we don't have everything we need to create the AutomationPeer yet, we'll just catch it and move forward. <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:06:42 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25013
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?