[PR #2609] Improve Accessibility Reliability #25018

Open
opened 2026-01-31 09:06:44 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/2609

State: closed
Merged: Yes


Summary of the Pull Request

Remove WindowUiaProvider entry points
Make TerminalAutomationPeer not crash the app if creation failed.

References

PR Checklist

  • Closes nothing
  • CLA signed.
  • Tests added/passed
  • Requires documentation to be updated
  • I'm a core contributor

Detailed Description of the Pull Request / Additional comments

WindowUiaProvider was something I thought we needed. We still need it for signaling (maybe). But it sometimes can crash because it's not hooked up properly at all. For now, I removed all entry points. After the signaling model gets added for #2447, I'll decide if we actually need to remove it.

Also surrounded the TerminalControlAutomationPeer with a try/catch. If we don't have everything we need to create the AutomationPeer yet, we'll just catch it and move forward.

Validation Steps Performed

**Original Pull Request:** https://github.com/microsoft/terminal/pull/2609 **State:** closed **Merged:** Yes --- <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Remove WindowUiaProvider entry points Make TerminalAutomationPeer not crash the app if creation failed. <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes nothing * [x] CLA signed. * [x] ~Tests added/passed~ * [x] ~Requires documentation to be updated~ * [x] I'm a core contributor <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments WindowUiaProvider was something I thought we needed. We still need it for signaling (maybe). But it sometimes can crash because it's not hooked up properly at all. For now, I removed all entry points. After the signaling model gets added for #2447, I'll decide if we actually need to remove it. Also surrounded the TerminalControlAutomationPeer with a try/catch. If we don't have everything we need to create the AutomationPeer yet, we'll just catch it and move forward. <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed
claunia added the pull-request label 2026-01-31 09:06:44 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25018