starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #2660] [MERGED] warnings as errors for cppwinrt projects and fix the warnings. #25024

New Issue
Open
opened 2026-01-31 09:06:46 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:06:46 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/2660
Author: @miniksa
Created: 9/4/2019
Status: ✅ Merged
Merged: 9/5/2019
Merged by: @DHowett-MSFT

Base: master ← Head: dev/miniksa/cascadia_warnings

📝 Commits (5)

  • 55c2467 warnings as errors for cppwinrt projects and fix the warnings.
  • 0d8cdf9 signed/unsigned mismatch.
  • 2fa1446 code formatting
  • df16ab6 Merge branch 'master' into dev/miniksa/cascadia_warnings
  • 3eb5d83 fix warnings after merge from master.

📊 Changes

8 files changed (+42 additions, -37 deletions)

View changed files

📝 src/cascadia/TerminalApp/CascadiaSettings.cpp (+1 -1)
📝 src/cascadia/TerminalConnection/AzureConnection.cpp (+31 -27)
📝 src/cascadia/TerminalControl/TermControl.cpp (+1 -1)
📝 src/cascadia/TerminalControl/TermControlAutomationPeer.cpp (+1 -1)
📝 src/cascadia/WindowsTerminal/AppHost.cpp (+2 -2)
📝 src/cascadia/WindowsTerminal/IslandWindow.h (+2 -2)
📝 src/cascadia/WindowsTerminal/WindowUiaProvider.cpp (+3 -3)
📝 src/cppwinrt.build.pre.props (+1 -0)

📄 Description

PR Checklist

  • Closes something that bothered me while setting up audit
  • I'm an employee
  • No tests, it's a warnings thing
  • No documentation
  • I'm a core contributor

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/2660 **Author:** [@miniksa](https://github.com/miniksa) **Created:** 9/4/2019 **Status:** ✅ Merged **Merged:** 9/5/2019 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `dev/miniksa/cascadia_warnings` --- ### 📝 Commits (5) - [`55c2467`](https://github.com/microsoft/terminal/commit/55c2467a05f7de5352ec24877284683622cec8df) warnings as errors for cppwinrt projects and fix the warnings. - [`0d8cdf9`](https://github.com/microsoft/terminal/commit/0d8cdf9bec6d05792ba58c91c3b7de543beb7941) signed/unsigned mismatch. - [`2fa1446`](https://github.com/microsoft/terminal/commit/2fa144645d871fc60d3d3da1590d98cb45e33968) code formatting - [`df16ab6`](https://github.com/microsoft/terminal/commit/df16ab63a2d23149f2321eee9d31d6a3c5c01b6a) Merge branch 'master' into dev/miniksa/cascadia_warnings - [`3eb5d83`](https://github.com/microsoft/terminal/commit/3eb5d83b0691f89fe11a4d7d6a922d5838f4050e) fix warnings after merge from master. ### 📊 Changes **8 files changed** (+42 additions, -37 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/CascadiaSettings.cpp` (+1 -1) 📝 `src/cascadia/TerminalConnection/AzureConnection.cpp` (+31 -27) 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+1 -1) 📝 `src/cascadia/TerminalControl/TermControlAutomationPeer.cpp` (+1 -1) 📝 `src/cascadia/WindowsTerminal/AppHost.cpp` (+2 -2) 📝 `src/cascadia/WindowsTerminal/IslandWindow.h` (+2 -2) 📝 `src/cascadia/WindowsTerminal/WindowUiaProvider.cpp` (+3 -3) 📝 `src/cppwinrt.build.pre.props` (+1 -0) </details> ### 📄 Description <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [X] Closes something that bothered me while setting up audit * [X] I'm an employee * [X] No tests, it's a warnings thing * [X] No documentation * [X] I'm a core contributor --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:06:47 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25024
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?