[PR #2750] [CLOSED] Add suppressApplicationTitle setting #25049

Open
opened 2026-01-31 09:06:56 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/2750
Author: @cinnamon-msft
Created: 9/13/2019
Status: Closed

Base: masterHead: cinnamon/suppress-tab-title


📝 Commits (4)

  • 3cc2498 added profiles.json schema to doc folder
  • 4989dc3 added suppressApplicationTitle
  • 56c7c18 removed JSON schema draft
  • 5f0d0b7 fixed documentation nits

📊 Changes

4 files changed (+96 additions, -0 deletions)

View changed files

📝 doc/cascadia/SettingsSchema.md (+1 -0)
📝 src/cascadia/TerminalApp/App.cpp (+51 -0)
📝 src/cascadia/TerminalApp/Profile.cpp (+40 -0)
📝 src/cascadia/TerminalApp/Profile.h (+4 -0)

📄 Description

Summary of the Pull Request

Added suppressApplicationTitle as an optional profile setting
Will override tabTitle if set
JSON schema will need to be updated once it's merged

References

PR Checklist

  • Closes Bug Report - Icon in taskbar popup is missing (#2645)
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Set both tabTitle and suppressApplicationTitle -> suppressApplicationTitle won out
Set only suppressApplicationTitle -> suppressApplicationTitle won out


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/2750 **Author:** [@cinnamon-msft](https://github.com/cinnamon-msft) **Created:** 9/13/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `cinnamon/suppress-tab-title` --- ### 📝 Commits (4) - [`3cc2498`](https://github.com/microsoft/terminal/commit/3cc2498d30c875226b2841ca06b735d887eba0a7) added profiles.json schema to doc folder - [`4989dc3`](https://github.com/microsoft/terminal/commit/4989dc31c33289109fe2694330604c88e6809e22) added suppressApplicationTitle - [`56c7c18`](https://github.com/microsoft/terminal/commit/56c7c181be5f0675d1adbb18538c8cde0f1130ac) removed JSON schema draft - [`5f0d0b7`](https://github.com/microsoft/terminal/commit/5f0d0b758b8c54a90ff5b743cafc3e0f5c00f67e) fixed documentation nits ### 📊 Changes **4 files changed** (+96 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/SettingsSchema.md` (+1 -0) 📝 `src/cascadia/TerminalApp/App.cpp` (+51 -0) 📝 `src/cascadia/TerminalApp/Profile.cpp` (+40 -0) 📝 `src/cascadia/TerminalApp/Profile.h` (+4 -0) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Added `suppressApplicationTitle` as an optional profile setting Will override `tabTitle` if set JSON schema will need to be updated once it's merged <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #2645 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Requires documentation to be updated * [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed Set both `tabTitle` and `suppressApplicationTitle` -> `suppressApplicationTitle` won out Set only `suppressApplicationTitle` -> `suppressApplicationTitle` won out --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:06:56 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25049