[PR #2789] [MERGED] Don't explode name-only profiles #25059

Open
opened 2026-01-31 09:07:00 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/2789
Author: @zadjii-msft
Created: 9/17/2019
Status: Merged
Merged: 9/17/2019
Merged by: @zadjii-msft

Base: masterHead: dev/migrie/b/2782-name-only-explode


📝 Commits (8)

📊 Changes

4 files changed (+187 additions, -0 deletions)

View changed files

📝 src/cascadia/LocalTests_TerminalApp/SettingsTests.cpp (+158 -0)
📝 src/cascadia/TerminalApp/CascadiaSettingsSerialization.cpp (+17 -0)
📝 src/cascadia/TerminalApp/Profile.cpp (+10 -0)
📝 src/cascadia/TerminalApp/Profile.h (+2 -0)

📄 Description

Summary of the Pull Request

When the user adds a name-only profile, we shouldn't re-add that to their list of profiles each time they launch the terminal.

References

Introduced in #2515 or #2603

PR Checklist


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/2789 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 9/17/2019 **Status:** ✅ Merged **Merged:** 9/17/2019 **Merged by:** [@zadjii-msft](https://github.com/zadjii-msft) **Base:** `master` ← **Head:** `dev/migrie/b/2782-name-only-explode` --- ### 📝 Commits (8) - [`907ebcd`](https://github.com/microsoft/terminal/commit/907ebcd5e433378796ca9a58d2d726fa1cd61826) Add a test for #2782 - [`f204b98`](https://github.com/microsoft/terminal/commit/f204b981770a5630ad489dd81d50ec3ccca56682) Attempt to do something weird with _GenerateStub - [`85b8b8a`](https://github.com/microsoft/terminal/commit/85b8b8a53cbe05a7c1b37f15e425daf5bae02fb4) Add some more notes on why this was a bad idea - [`3feaefe`](https://github.com/microsoft/terminal/commit/3feaefe9470f2304f067ca2d556c2cc64b457174) Actually fix the issue at hand - [`30c0bc3`](https://github.com/microsoft/terminal/commit/30c0bc3a1f2cde585bf78de5f64146300259c823) Revert "Add some more notes on why this was a bad idea" - [`1ef2074`](https://github.com/microsoft/terminal/commit/1ef20747034facd8e1897f04c5aaec0c7c3988ef) Revert "Attempt to do something weird with _GenerateStub" - [`8ae7dee`](https://github.com/microsoft/terminal/commit/8ae7dee7f1edc549da2b7f5a6d7037c8a3f24b0b) Little test fixes - [`be1d305`](https://github.com/microsoft/terminal/commit/be1d3051f85d8cc7eb5a65f92b19a8a14509ccb8) Update src/cascadia/TerminalApp/CascadiaSettingsSerialization.cpp ### 📊 Changes **4 files changed** (+187 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/LocalTests_TerminalApp/SettingsTests.cpp` (+158 -0) 📝 `src/cascadia/TerminalApp/CascadiaSettingsSerialization.cpp` (+17 -0) 📝 `src/cascadia/TerminalApp/Profile.cpp` (+10 -0) 📝 `src/cascadia/TerminalApp/Profile.h` (+2 -0) </details> ### 📄 Description ## Summary of the Pull Request When the user adds a name-only profile, we shouldn't re-add that to their list of profiles each time they launch the terminal. ## References Introduced in #2515 or #2603 ## PR Checklist * [x] Closes #2782 * [x] I work here * [x] Tests added/passed * [n/a] Requires documentation to be updated --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:07:00 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25059