[PR #2800] [MERGED] Add validation for hiding all the profiles #25069

Open
opened 2026-01-31 09:07:06 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/2800
Author: @zadjii-msft
Created: 9/18/2019
Status: Merged
Merged: 9/19/2019
Merged by: @undefined

Base: masterHead: dev/migrie/b/2794-hide-all-explode


📝 Commits (1)

  • 3dfc353 Add validation for hiding all the profiles

📊 Changes

5 files changed (+85 additions, -3 deletions)

View changed files

📝 src/cascadia/LocalTests_TerminalApp/SettingsTests.cpp (+66 -0)
📝 src/cascadia/TerminalApp/App.cpp (+3 -2)
📝 src/cascadia/TerminalApp/CascadiaSettings.cpp (+10 -0)
📝 src/cascadia/TerminalApp/Resources/en-US/Resources.resw (+4 -0)
📝 src/cascadia/TerminalApp/TerminalWarnings.h (+2 -1)

📄 Description

Summary of the Pull Request

Prevent the Terminal from toasting it's marshmallows when the user hides all their profiles. In that case, we'll just revert to the defaults.

PR Checklist

Validation Steps Performed

  • ran tests
  • validated manually

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/2800 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 9/18/2019 **Status:** ✅ Merged **Merged:** 9/19/2019 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `dev/migrie/b/2794-hide-all-explode` --- ### 📝 Commits (1) - [`3dfc353`](https://github.com/microsoft/terminal/commit/3dfc353b8a3f53f0d19f7db748faa7ab658d3f56) Add validation for hiding all the profiles ### 📊 Changes **5 files changed** (+85 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/LocalTests_TerminalApp/SettingsTests.cpp` (+66 -0) 📝 `src/cascadia/TerminalApp/App.cpp` (+3 -2) 📝 `src/cascadia/TerminalApp/CascadiaSettings.cpp` (+10 -0) 📝 `src/cascadia/TerminalApp/Resources/en-US/Resources.resw` (+4 -0) 📝 `src/cascadia/TerminalApp/TerminalWarnings.h` (+2 -1) </details> ### 📄 Description ## Summary of the Pull Request Prevent the Terminal from toasting it's marshmallows when the user hides all their profiles. In that case, we'll just revert to the defaults. ## PR Checklist * [x] Closes #2794 * [x] I work here * [x] Tests added/passed * [n/a] Requires documentation to be updated ## Validation Steps Performed * ran tests * validated manually --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:07:06 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25069