[PR #2791] Remove null check from glyph run drawing #25075

Open
opened 2026-01-31 09:07:08 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/2791

State: closed
Merged: Yes


Summary of the Pull Request

Removes the null check introduced for static analysis purposes as the parameter is truly optional.

PR Checklist

Validation Steps Performed

Changed the null check. Ran it with some emoji.

**Original Pull Request:** https://github.com/microsoft/terminal/pull/2791 **State:** closed **Merged:** Yes --- <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Removes the null check introduced for static analysis purposes as the parameter is truly optional. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [X] Closes #2724 * [X] I work here * [X] No tests, I just ran it. * [X] No docs. * [X] I'm a core contributor <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed Changed the null check. Ran it with some emoji.
claunia added the pull-request label 2026-01-31 09:07:08 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25075