[PR #2824] [MERGED] Enable VT processing by default for conpty #25101

Open
opened 2026-01-31 09:07:17 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/2824
Author: @zadjii-msft
Created: 9/20/2019
Status: Merged
Merged: 9/23/2019
Merged by: @DHowett-MSFT

Base: masterHead: dev/migrie/b/1965-vt-all-the-things


📝 Commits (2)

  • 6bb227a Enable VT processing by default for conpty
  • e9fc3dd Update src/host/srvinit.cpp

📊 Changes

1 file changed (+11 additions, -0 deletions)

View changed files

📝 src/host/srvinit.cpp (+11 -0)

📄 Description

Summary of the Pull Request

This change enables VT processing by default for all conpty clients. See #1965 for a discussion on why we believe this is a righteous change.

PR Checklist

Detailed Description of the Pull Request / Additional comments

Also mentioned in the issue was the idea of only checking the VirtualTerminalLevel reg key in the conpty startup. I don't think this would be a more difficult change, looks like all we'd need is a simple reg.LoadGlobalsFromRegistry(); call instead of this change.

Validation Steps Performed

Manually launched a scratch app in both the terminal and the console. The console launch's output mode was 0x3, and the terminal's was 0x7. 0x4 is the ENABLE_VIRTUAL_TERMINAL_PROCESSING flag, which the client now had by default in the Terminal.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/2824 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 9/20/2019 **Status:** ✅ Merged **Merged:** 9/23/2019 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `dev/migrie/b/1965-vt-all-the-things` --- ### 📝 Commits (2) - [`6bb227a`](https://github.com/microsoft/terminal/commit/6bb227a20af72f82b2ae0aed1a789f7fa28a7446) Enable VT processing by default for conpty - [`e9fc3dd`](https://github.com/microsoft/terminal/commit/e9fc3dd47763914c65ccd64f07faa8ac7c9239a2) Update src/host/srvinit.cpp ### 📊 Changes **1 file changed** (+11 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/host/srvinit.cpp` (+11 -0) </details> ### 📄 Description ## Summary of the Pull Request This change enables VT processing by default for _all_ conpty clients. See #1965 for a discussion on why we believe this is a righteous change. ## PR Checklist * [x] Closes #1965 * [x] I work here * [ ] Tests added/passed - this might need them? * [ ] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments Also mentioned in the issue was the idea of only checking the `VirtualTerminalLevel` reg key in the conpty startup. I don't think this would be a more difficult change, looks like all we'd need is a simple `reg.LoadGlobalsFromRegistry();` call instead of this change. ## Validation Steps Performed Manually launched a scratch app in both the terminal and the console. The console launch's output mode was 0x3, and the terminal's was 0x7. 0x4 is the ` ENABLE_VIRTUAL_TERMINAL_PROCESSING` flag, which the client now had by default in the Terminal. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:07:17 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25101