[PR #2823] [MERGED] Return to ground when we flush the last char #25102

Open
opened 2026-01-31 09:07:17 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/2823
Author: @zadjii-msft
Created: 9/20/2019
Status: Merged
Merged: 10/4/2019
Merged by: @zadjii-msft

Base: masterHead: dev/migrie/b/2746-return-to-ground


📝 Commits (4)

  • 37d8840 Return to ground when we flush the last char
  • 6319692 Update src/terminal/parser/stateMachine.cpp
  • b5f8926 Merge remote-tracking branch 'origin/master' into dev/migrie/b/2746-return-to-ground
  • cf185e5 add the comment @miniksa wanted

📊 Changes

5 files changed (+99 additions, -28 deletions)

View changed files

📝 src/terminal/parser/stateMachine.cpp (+32 -7)
📝 src/terminal/parser/ut_parser/InputEngineTest.cpp (+52 -0)
src/terminal/parser/ut_parser/Parser.UnitTests-common.vcxproj (+0 -19)
📝 src/terminal/parser/ut_parser/Parser.UnitTests.vcxproj (+14 -1)
📝 tools/bcz.cmd (+1 -1)

📄 Description

Summary of the Pull Request

The InputStateMachineEngine was incorrectly not returning to the ground state after flushing the last sequence. That means that something like alt+backspace would leave us in the Escape state, not the ground state. This makes sure we return to ground.

Additionally removes the "Parser.UnitTests-common.vcxproj" file, which was originally used for a theoretical time when we only open-sourced the parser. It's unnecessary now, and we can get rid of it.

Also includes a small patch to bcz.cmd, to make sure bx works with projects with a space in their name.

PR Checklist


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/2823 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 9/20/2019 **Status:** ✅ Merged **Merged:** 10/4/2019 **Merged by:** [@zadjii-msft](https://github.com/zadjii-msft) **Base:** `master` ← **Head:** `dev/migrie/b/2746-return-to-ground` --- ### 📝 Commits (4) - [`37d8840`](https://github.com/microsoft/terminal/commit/37d88405e937be9e1da620faf4d44bd28bb5488d) Return to ground when we flush the last char - [`6319692`](https://github.com/microsoft/terminal/commit/631969250eec404bfd8226ea6227d12a2efae09d) Update src/terminal/parser/stateMachine.cpp - [`b5f8926`](https://github.com/microsoft/terminal/commit/b5f89265b856d2058175e7a86daf4878d7c58e19) Merge remote-tracking branch 'origin/master' into dev/migrie/b/2746-return-to-ground - [`cf185e5`](https://github.com/microsoft/terminal/commit/cf185e529ebee0f09101d58834032fdc5eea29b0) add the comment @miniksa wanted ### 📊 Changes **5 files changed** (+99 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `src/terminal/parser/stateMachine.cpp` (+32 -7) 📝 `src/terminal/parser/ut_parser/InputEngineTest.cpp` (+52 -0) ➖ `src/terminal/parser/ut_parser/Parser.UnitTests-common.vcxproj` (+0 -19) 📝 `src/terminal/parser/ut_parser/Parser.UnitTests.vcxproj` (+14 -1) 📝 `tools/bcz.cmd` (+1 -1) </details> ### 📄 Description ## Summary of the Pull Request The InputStateMachineEngine was incorrectly not returning to the ground state after flushing the last sequence. That means that something like alt+backspace would leave us in the Escape state, not the ground state. This makes sure we return to ground. Additionally removes the "Parser.UnitTests-common.vcxproj" file, which was originally used for a theoretical time when we only open-sourced the parser. It's unnecessary now, and we can get rid of it. Also includes a small patch to bcz.cmd, to make sure bx works with projects with a space in their name. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #2746 * [x] I work here * [x] Tests added/passed * [n/a] Requires documentation to be updated --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:07:17 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25102