[PR #2843] [MERGED] Update path to profiles.json in documentation #25112

Open
opened 2026-01-31 09:07:20 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/2843
Author: @GageAmes
Created: 9/22/2019
Status: Merged
Merged: 9/23/2019
Merged by: @carlos-zamora

Base: masterHead: localstate-doc-update


📝 Commits (1)

  • b060039 Update path to profiles.json in documentation

📊 Changes

2 files changed (+4 additions, -4 deletions)

View changed files

📝 doc/user-docs/UsingJsonSettings.md (+3 -3)
📝 doc/user-docs/index.md (+1 -1)

📄 Description

Summary of the Pull Request

The profiles.json file was moved from RoamingState to LocalState in PR #2298. This PR updates the documentation to reflect this change.

References

PR #2298

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

I searched through the documentation for references to RoamingState in relation to profiles.json and changed RoamingState to LocalState for such instances. The configuration example for adding a custom background could technically continue to reference the roaming path, but I felt it was best to change it to the local path since it referenced this path as the "same directory as your profiles.json file."

Validation Steps Performed

Documentation update only, so no validation was performed.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/2843 **Author:** [@GageAmes](https://github.com/GageAmes) **Created:** 9/22/2019 **Status:** ✅ Merged **Merged:** 9/23/2019 **Merged by:** [@carlos-zamora](https://github.com/carlos-zamora) **Base:** `master` ← **Head:** `localstate-doc-update` --- ### 📝 Commits (1) - [`b060039`](https://github.com/microsoft/terminal/commit/b060039416a0139029218fee3a27d67e3213ee12) Update path to profiles.json in documentation ### 📊 Changes **2 files changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `doc/user-docs/UsingJsonSettings.md` (+3 -3) 📝 `doc/user-docs/index.md` (+1 -1) </details> ### 📄 Description ## Summary of the Pull Request The `profiles.json` file was moved from RoamingState to LocalState in PR #2298. This PR updates the documentation to reflect this change. ## References PR #2298 ## PR Checklist * [ ] Closes #xxx * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Requires documentation to be updated * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx ## Detailed Description of the Pull Request / Additional comments I searched through the documentation for references to RoamingState in relation to `profiles.json` and changed RoamingState to LocalState for such instances. The configuration example for adding a custom background could technically continue to reference the roaming path, but I felt it was best to change it to the local path since it referenced this path as the "same directory as your `profiles.json` file." ## Validation Steps Performed Documentation update only, so no validation was performed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:07:20 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25112