starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #2945] [MERGED] Attempt to make the build work again #25159

New Issue
Open
opened 2026-01-31 09:07:41 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:07:41 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/2945
Author: @miniksa
Created: 9/27/2019
Status: ✅ Merged
Merged: 9/30/2019
Merged by: @DHowett-MSFT

Base: master ← Head: dev/miniksa/buuuuh

📝 Commits (6)

  • e3961f7 Revert "Add source linking information during the build (#2857)"
  • 64027c0 Need reference to renderer base inside UnitTests_TerminalCore
  • a7a8002 add dependency for TerminalControl to Types project.
  • 3caf70b Set build to single threaded as parallel build is broken by 16.3 build toolchain.
  • c944de7 Disable new rule C26814 as it's breaking builds
  • 67079ae Add noexcept to dx header.

📊 Changes

26 files changed (+59 additions, -305 deletions)

View changed files

📝 build/pipelines/templates/build-console-steps.yml (+2 -11)
➖ build/scripts/Index-Pdbs.ps1 (+0 -85)
📝 src/StaticAnalysis.ruleset (+2 -0)
📝 src/cascadia/TerminalApp/TerminalApp.vcxproj (+15 -19)
📝 src/cascadia/TerminalApp/packages.config (+1 -4)
📝 src/cascadia/TerminalConnection/TerminalConnection.vcxproj (+2 -14)
📝 src/cascadia/TerminalConnection/TerminalConnection.vcxproj.filters (+0 -1)
📝 src/cascadia/TerminalConnection/packages.config (+1 -4)
📝 src/cascadia/TerminalControl/TerminalControl.vcxproj (+2 -18)
📝 src/cascadia/TerminalControl/TerminalControl.vcxproj.filters (+1 -2)
📝 src/cascadia/TerminalControl/packages.config (+1 -4)
📝 src/cascadia/TerminalSettings/TerminalSettings.vcxproj (+2 -18)
📝 src/cascadia/TerminalSettings/packages.config (+1 -4)
📝 src/cascadia/UnitTests_TerminalCore/UnitTests.vcxproj (+4 -1)
📝 src/cascadia/WindowsTerminal/WindowsTerminal.vcxproj (+13 -14)
📝 src/cascadia/WindowsTerminal/packages.config (+2 -5)
📝 src/host/exe/Host.EXE.vcxproj (+0 -20)
📝 src/host/exe/Host.EXE.vcxproj.filters (+0 -6)
➖ src/host/exe/packages.config (+0 -6)
➖ src/propsheet/packages.config (+0 -6)

...and 6 more files

📄 Description

  • Remove sourcelink because it's not compatible with 16.3 and causes multiwrite on the PDB issues
    (this can be alleviated slightly by calling /FS despite the fact that we were already calling /MP which was supposed to imply /FS)
  • Stop parallel builds because apparently they're toast now
  • Halt the new warning C26814 because we haven't solved it yet and it's brand new
  • Add references and dependencies to projects that are missing them that were apparently fine with 16.2 but not 16.3

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/2945 **Author:** [@miniksa](https://github.com/miniksa) **Created:** 9/27/2019 **Status:** ✅ Merged **Merged:** 9/30/2019 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `dev/miniksa/buuuuh` --- ### 📝 Commits (6) - [`e3961f7`](https://github.com/microsoft/terminal/commit/e3961f7d240c194f91339fb667bac726ebfb3444) Revert "Add source linking information during the build (#2857)" - [`64027c0`](https://github.com/microsoft/terminal/commit/64027c04c17a14494aa8fd79664616ab68c69dd5) Need reference to renderer base inside UnitTests_TerminalCore - [`a7a8002`](https://github.com/microsoft/terminal/commit/a7a80026cf0fe4b26ebb6740d7f02c85b6af001f) add dependency for TerminalControl to Types project. - [`3caf70b`](https://github.com/microsoft/terminal/commit/3caf70be2d22503b001614197ffc2402d6dcb41f) Set build to single threaded as parallel build is broken by 16.3 build toolchain. - [`c944de7`](https://github.com/microsoft/terminal/commit/c944de79a28b9c9bb6c8e3cf36c90951e23b5ee0) Disable new rule C26814 as it's breaking builds - [`67079ae`](https://github.com/microsoft/terminal/commit/67079aed463bda72bec49611beb7899747fbed9b) Add noexcept to dx header. ### 📊 Changes **26 files changed** (+59 additions, -305 deletions) <details> <summary>View changed files</summary> 📝 `build/pipelines/templates/build-console-steps.yml` (+2 -11) ➖ `build/scripts/Index-Pdbs.ps1` (+0 -85) 📝 `src/StaticAnalysis.ruleset` (+2 -0) 📝 `src/cascadia/TerminalApp/TerminalApp.vcxproj` (+15 -19) 📝 `src/cascadia/TerminalApp/packages.config` (+1 -4) 📝 `src/cascadia/TerminalConnection/TerminalConnection.vcxproj` (+2 -14) 📝 `src/cascadia/TerminalConnection/TerminalConnection.vcxproj.filters` (+0 -1) 📝 `src/cascadia/TerminalConnection/packages.config` (+1 -4) 📝 `src/cascadia/TerminalControl/TerminalControl.vcxproj` (+2 -18) 📝 `src/cascadia/TerminalControl/TerminalControl.vcxproj.filters` (+1 -2) 📝 `src/cascadia/TerminalControl/packages.config` (+1 -4) 📝 `src/cascadia/TerminalSettings/TerminalSettings.vcxproj` (+2 -18) 📝 `src/cascadia/TerminalSettings/packages.config` (+1 -4) 📝 `src/cascadia/UnitTests_TerminalCore/UnitTests.vcxproj` (+4 -1) 📝 `src/cascadia/WindowsTerminal/WindowsTerminal.vcxproj` (+13 -14) 📝 `src/cascadia/WindowsTerminal/packages.config` (+2 -5) 📝 `src/host/exe/Host.EXE.vcxproj` (+0 -20) 📝 `src/host/exe/Host.EXE.vcxproj.filters` (+0 -6) ➖ `src/host/exe/packages.config` (+0 -6) ➖ `src/propsheet/packages.config` (+0 -6) _...and 6 more files_ </details> ### 📄 Description - Remove sourcelink because it's not compatible with 16.3 and causes multiwrite on the PDB issues (this can be alleviated slightly by calling /FS despite the fact that we were already calling /MP which was supposed to imply /FS) - Stop parallel builds because apparently they're toast now - Halt the new warning C26814 because we haven't solved it yet and it's brand new - Add references and dependencies to projects that are missing them that were apparently fine with 16.2 but not 16.3 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:07:41 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25159
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?