starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #2942] [CLOSED] Disable new rule C26814 as it's breaking builds #25162

New Issue
Open
opened 2026-01-31 09:07:42 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:07:42 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/2942
Author: @miniksa
Created: 9/27/2019
Status: ❌ Closed

Base: master ← Head: audit-patch

📝 Commits (7)

  • 499384f Disable new rule C26814 as it's breaking builds
  • d9ce822 Add noexcept to dx header.
  • a7ef967 Try removing pch deletion step... they look smaller with the 16.3 toolkit...
  • b32f7f3 Add missing reference.
  • 9fea3bf Set build to single threaded as parallel build is broken by 16.3 build toolchain.
  • 275851d Try throwing a few more things at the wall. Try /FS even though /MP is supposed to imply it. Try adding more dependencies and build ordering rules to get it going.
  • 9e0b109 Try removing references from TerminalApp that are already stitched into TerminalAppLib

📊 Changes

12 files changed (+34 additions, -16 deletions)

View changed files

📝 .gitignore (+3 -0)
📝 OpenConsole.sln (+15 -0)
📝 build/pipelines/templates/build-console-steps.yml (+1 -1)
📝 src/StaticAnalysis.ruleset (+2 -0)
📝 src/cascadia/TerminalApp/TerminalApp.vcxproj (+1 -7)
📝 src/cascadia/TerminalControl/TerminalControl.vcxproj (+2 -1)
📝 src/cascadia/UnitTests_TerminalCore/UnitTests.vcxproj (+4 -1)
📝 src/common.build.post.props (+2 -2)
📝 src/common.build.pre.props (+1 -1)
📝 src/cppwinrt.build.pre.props (+1 -1)
📝 src/renderer/dx/DxRenderer.cpp (+1 -1)
📝 src/renderer/dx/DxRenderer.hpp (+1 -1)

📄 Description

Wrote a follow up task #2941 to roll it out later.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/2942 **Author:** [@miniksa](https://github.com/miniksa) **Created:** 9/27/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `audit-patch` --- ### 📝 Commits (7) - [`499384f`](https://github.com/microsoft/terminal/commit/499384f17627d4a4c3a0f183294bed45b250b08f) Disable new rule C26814 as it's breaking builds - [`d9ce822`](https://github.com/microsoft/terminal/commit/d9ce822da9dcd4edfa1676ad5d0e7a7d7d225b0c) Add noexcept to dx header. - [`a7ef967`](https://github.com/microsoft/terminal/commit/a7ef967fc26595bf46d177181700feb7f8df6d57) Try removing pch deletion step... they look smaller with the 16.3 toolkit... - [`b32f7f3`](https://github.com/microsoft/terminal/commit/b32f7f33634ff1620d194d81393b9dc78dd845ba) Add missing reference. - [`9fea3bf`](https://github.com/microsoft/terminal/commit/9fea3bf12d6fefe49af9c0bb7240669b4fd8ef3f) Set build to single threaded as parallel build is broken by 16.3 build toolchain. - [`275851d`](https://github.com/microsoft/terminal/commit/275851df4b1eb9356e58902b6f7927c51e919078) Try throwing a few more things at the wall. Try /FS even though /MP is supposed to imply it. Try adding more dependencies and build ordering rules to get it going. - [`9e0b109`](https://github.com/microsoft/terminal/commit/9e0b10975946c06cec0f819c7cd1f9fa89a2fdac) Try removing references from TerminalApp that are already stitched into TerminalAppLib ### 📊 Changes **12 files changed** (+34 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+3 -0) 📝 `OpenConsole.sln` (+15 -0) 📝 `build/pipelines/templates/build-console-steps.yml` (+1 -1) 📝 `src/StaticAnalysis.ruleset` (+2 -0) 📝 `src/cascadia/TerminalApp/TerminalApp.vcxproj` (+1 -7) 📝 `src/cascadia/TerminalControl/TerminalControl.vcxproj` (+2 -1) 📝 `src/cascadia/UnitTests_TerminalCore/UnitTests.vcxproj` (+4 -1) 📝 `src/common.build.post.props` (+2 -2) 📝 `src/common.build.pre.props` (+1 -1) 📝 `src/cppwinrt.build.pre.props` (+1 -1) 📝 `src/renderer/dx/DxRenderer.cpp` (+1 -1) 📝 `src/renderer/dx/DxRenderer.hpp` (+1 -1) </details> ### 📄 Description Wrote a follow up task #2941 to roll it out later. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:07:42 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25162
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?