[PR #3033] [MERGED] Add a warning when a profile has an unknown color scheme #25219

Open
opened 2026-01-31 09:08:04 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/3033
Author: @zadjii-msft
Created: 10/2/2019
Status: ✅ Merged
Merged: 10/15/2019
Merged by: @DHowett-MSFT

Base: master ← Head: dev/migrie/b/2547-validate-schemes


📝 Commits (5)

📊 Changes

13 files changed (+249 additions, -158 deletions)

View changed files

📝 src/cascadia/LocalTests_TerminalApp/ColorSchemeTests.cpp (+75 -37)
📝 src/cascadia/LocalTests_TerminalApp/SettingsTests.cpp (+65 -2)
📝 src/cascadia/TerminalApp/App.cpp (+3 -2)
📝 src/cascadia/TerminalApp/CascadiaSettings.cpp (+35 -1)
📝 src/cascadia/TerminalApp/CascadiaSettings.h (+1 -2)
📝 src/cascadia/TerminalApp/CascadiaSettingsSerialization.cpp (+3 -54)
📝 src/cascadia/TerminalApp/GlobalAppSettings.cpp (+14 -2)
📝 src/cascadia/TerminalApp/GlobalAppSettings.h (+7 -3)
📝 src/cascadia/TerminalApp/Profile.cpp (+9 -25)
📝 src/cascadia/TerminalApp/Profile.h (+2 -1)
📝 src/cascadia/TerminalApp/Resources/en-US/Resources.resw (+32 -28)
📝 src/cascadia/TerminalApp/TerminalWarnings.h (+2 -1)
📝 src/cascadia/ut_app/JsonTests.cpp (+1 -0)

📄 Description

Summary of the Pull Request

Add a warning when the user sets their colorScheme to a scheme that doesn't exists. When that occurs, we'll set their color table to the campbell scheme, to prevent it from being just entirely black.

PR Checklist


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/3033 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 10/2/2019 **Status:** ✅ Merged **Merged:** 10/15/2019 **Merged by:** [@DHowett-MSFT](https://github.com/DHowett-MSFT) **Base:** `master` ← **Head:** `dev/migrie/b/2547-validate-schemes` --- ### 📝 Commits (5) - [`0a4fc24`](https://github.com/microsoft/terminal/commit/0a4fc243f3dacbee62e0d7d58cb249703760cebe) fixes #2547 - [`3206644`](https://github.com/microsoft/terminal/commit/3206644cca5610637be068c4c6862be45b630cb2) Well this was an enormous pain - [`bfc6c61`](https://github.com/microsoft/terminal/commit/bfc6c618a8cc6b83285b417185b5fc0ee6d723b2) Final bits of polish on the vector->map change - [`5988373`](https://github.com/microsoft/terminal/commit/598837339d5bd153ab2605846bcf6c13a185d92c) CR feedback - [`6bca16e`](https://github.com/microsoft/terminal/commit/6bca16ef63d391dbb2fef947936518287d3cb76a) Merge remote-tracking branch 'github/master' into HEAD ### 📊 Changes **13 files changed** (+249 additions, -158 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/LocalTests_TerminalApp/ColorSchemeTests.cpp` (+75 -37) 📝 `src/cascadia/LocalTests_TerminalApp/SettingsTests.cpp` (+65 -2) 📝 `src/cascadia/TerminalApp/App.cpp` (+3 -2) 📝 `src/cascadia/TerminalApp/CascadiaSettings.cpp` (+35 -1) 📝 `src/cascadia/TerminalApp/CascadiaSettings.h` (+1 -2) 📝 `src/cascadia/TerminalApp/CascadiaSettingsSerialization.cpp` (+3 -54) 📝 `src/cascadia/TerminalApp/GlobalAppSettings.cpp` (+14 -2) 📝 `src/cascadia/TerminalApp/GlobalAppSettings.h` (+7 -3) 📝 `src/cascadia/TerminalApp/Profile.cpp` (+9 -25) 📝 `src/cascadia/TerminalApp/Profile.h` (+2 -1) 📝 `src/cascadia/TerminalApp/Resources/en-US/Resources.resw` (+32 -28) 📝 `src/cascadia/TerminalApp/TerminalWarnings.h` (+2 -1) 📝 `src/cascadia/ut_app/JsonTests.cpp` (+1 -0) </details> ### 📄 Description ## Summary of the Pull Request Add a warning when the user sets their `colorScheme` to a scheme that doesn't exists. When that occurs, we'll set their color table to the campbell scheme, to prevent it from being just entirely black. ## PR Checklist * [x] Closes #2547 * [x] I work here * [x] Tests added/passed * [n/a] Requires documentation to be updated --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:08:04 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25219