[PR #3049] Provide the CloseWindow warning experience for the 'X' button #25225

Open
opened 2026-01-31 09:08:05 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/3049

State: closed
Merged: Yes


This is a follow up project of #1589 , which warns users of multiple tabs opened when press ALT+F4.
Now we are going to connect this experience with the 'X' button of the window.

For now, this PR only includes the implementation for IslandWindow (client window). Non-client window experience is still under implementation.

References

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

To Test:

  1. Start terminal.
  2. Open multiple tabs.
  3. Click 'X' on the top right corner of the window.
  4. You should be able to see a warning. If you cancel it, then the Terminal keeps running.
  5. If you click 'Close', then the app will close.
  6. If you only have one tab opened, and click 'X', the app should close directly without any warnings.
**Original Pull Request:** https://github.com/microsoft/terminal/pull/3049 **State:** closed **Merged:** Yes --- <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> This is a follow up project of #1589 , which warns users of multiple tabs opened when press ALT+F4. Now we are going to connect this experience with the 'X' button of the window. For now, this PR only includes the implementation for IslandWindow (client window). Non-client window experience is still under implementation. <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [ ] Closes #xxx * [ ] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Requires documentation to be updated * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> To Test: 1. Start terminal. 2. Open multiple tabs. 3. Click 'X' on the top right corner of the window. 4. You should be able to see a warning. If you cancel it, then the Terminal keeps running. 5. If you click 'Close', then the app will close. 6. If you only have one tab opened, and click 'X', the app should close directly without any warnings.
claunia added the pull-request label 2026-01-31 09:08:05 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#25225